Fix setup.py and use of requirements files #853
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #853 +/- ##
=======================================
Coverage 94.79% 94.79%
=======================================
Files 59 59
Lines 9603 9603
=======================================
Hits 9103 9103
Misses 500 500
Continue to review full report at Codecov.
|
|
@Byron is it important to maintain support for Python 3.4? It doesn't understand some of the setup.py changes. I could mark the project as requiring Python 3.5 or later. This PR adds 3.6 and 3.7 testing to appveyor and it consolidates all the requirements logic for setup. Next PR will set some of the currently failing appveyor tests as allowed failures (miniconda variants). Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were requirements scattered about in both setup.py and requirements.txt - this consolidated them all into requirements files. It also adds python 3.5 and 3.6 to the tests.