Skip to content

Fix setup.py and use of requirements files #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,12 @@ environment:
- PYTHON: "C:\\Python35-x64"
PYTHON_VERSION: "3.5"
GIT_PATH: "%GIT_DAEMON_PATH%"
- PYTHON: "C:\\Python36-x64"
PYTHON_VERSION: "3.6"
GIT_PATH: "%GIT_DAEMON_PATH%"
- PYTHON: "C:\\Python37-x64"
PYTHON_VERSION: "3.7"
GIT_PATH: "%GIT_DAEMON_PATH%"
- PYTHON: "C:\\Miniconda35-x64"
PYTHON_VERSION: "3.5"
IS_CONDA: "yes"
Expand Down Expand Up @@ -51,6 +57,7 @@ install:
conda info -a &
conda install --yes --quiet pip
)
- pip install -r requirements.txt
- pip install -r test-requirements.txt
- pip install codecov

Expand Down
3 changes: 1 addition & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,7 @@ script:
- ulimit -n 128
- ulimit -n
- nosetests -v --with-coverage
- if [ "$TRAVIS_PYTHON_VERSION" == '3.4' ]; then flake8 --ignore=W293,E265,E266,W503,W504,E731; fi
- if [ "$TRAVIS_PYTHON_VERSION" == '3.5' ]; then cd doc && make html; fi
-
- if [ "$TRAVIS_PYTHON_VERSION" == '3.6' ]; then flake8 --ignore=W293,E265,E266,W503,W504,E731; fi
after_success:
- codecov
4 changes: 3 additions & 1 deletion MANIFEST.in
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,10 @@ include VERSION
include LICENSE
include CHANGES
include AUTHORS
include README
include CONTRIBUTING.md
include README.md
include requirements.txt
include test-requirements.txt

recursive-include doc *

Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ all:
@grep -Ee '^[a-z].*:' Makefile | cut -d: -f1 | grep -vF all

clean:
rm -rf build/ dist/
rm -rf build/ dist/ .eggs/ .tox/

release: clean
# Check if latest tag is the current head we're releasing
Expand Down
3 changes: 2 additions & 1 deletion git/cmd.py
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,8 @@ def refresh(cls, path=None):
# - a GitCommandNotFound error is spawned by ourselves
# - a PermissionError is spawned if the git executable provided
# cannot be executed for whatever reason
exceptions = (GitCommandNotFound, PermissionError)
exceptions = (GitCommandNotFound, PermissionError) # noqa
# (silence erroneous flake8 F821)

has_git = False
try:
Expand Down
3 changes: 1 addition & 2 deletions requirements.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
gitdb>=0.6.4
ddt>=1.1.1
gitdb2(>=2.0.0)
14 changes: 6 additions & 8 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@
with open('requirements.txt') as reqs_file:
requirements = reqs_file.read().splitlines()

with open('test-requirements.txt') as reqs_file:
test_requirements = reqs_file.read().splitlines()


class build_py(_build_py):

Expand Down Expand Up @@ -63,10 +66,6 @@ def _stamp_version(filename):
print("WARNING: Couldn't find version line in file %s" % filename, file=sys.stderr)


install_requires = ['gitdb2 >= 2.0.0']
test_requires = ['ddt>=1.1.1']
# end

setup(
name="GitPython",
cmdclass={'build_py': build_py, 'sdist': sdist},
Expand All @@ -81,9 +80,8 @@ def _stamp_version(filename):
package_dir={'git': 'git'},
license="BSD License",
python_requires='>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*',
requires=['gitdb2 (>=2.0.0)'],
install_requires=install_requires,
test_requirements=test_requires + install_requires,
requires=requirements,
tests_require=requirements + test_requirements,
zip_safe=False,
long_description="""GitPython is a python library used to interact with Git repositories""",
classifiers=[
Expand All @@ -110,6 +108,6 @@ def _stamp_version(filename):
"Programming Language :: Python :: 3.4",
"Programming Language :: Python :: 3.5",
"Programming Language :: Python :: 3.6",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.7"
]
)
5 changes: 2 additions & 3 deletions test-requirements.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
-r requirements.txt

ddt>=1.1.1
coverage
flake8
nose
mock; python_version=='2.7'
mock; python_version=='2.7'