Skip to content

Remove unnecessary helper function DateFmtLong #24343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 26, 2023
Merged

Remove unnecessary helper function DateFmtLong #24343

merged 9 commits into from
Apr 26, 2023

Conversation

yardenshoham
Copy link
Member

After #24317 this function is only used in one place where it is not needed. I confirmed the timestamp still renders correctly

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 25, 2023
@yardenshoham yardenshoham added this to the 1.20.0 milestone Apr 25, 2023
@yardenshoham yardenshoham added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Apr 25, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 25, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 26, 2023
@techknowlogick techknowlogick added type/refactoring Existing code has been cleaned up. There should be no new functionality. reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Apr 26, 2023
@techknowlogick techknowlogick enabled auto-merge (squash) April 26, 2023 03:13
@techknowlogick techknowlogick merged commit eea23bb into go-gitea:main Apr 26, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 26, 2023
@yardenshoham yardenshoham deleted the remove-date-fmt-long branch April 26, 2023 08:08
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
5 participants
@yardenshoham @silverwind @wxiaoguang @techknowlogick @GiteaBot