Skip to content

Remove unnecessary helper function DateFmtLong #24343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 26, 2023
Merged

Remove unnecessary helper function DateFmtLong #24343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
498eba4
Remove unnecessary helper function `DateFmtLong`
yardenshoham Apr 25, 2023
a476ff2
Merge branch 'main' into remove-date-fmt-long
GiteaBot Apr 26, 2023
a7c0630
Merge branch 'main' into remove-date-fmt-long
GiteaBot Apr 26, 2023
697648d
Merge branch 'main' into remove-date-fmt-long
GiteaBot Apr 26, 2023
c187352
Merge branch 'main' into remove-date-fmt-long
GiteaBot Apr 26, 2023
91b0200
Merge branch 'main' into remove-date-fmt-long
GiteaBot Apr 26, 2023
88ab606
Merge branch 'main' into remove-date-fmt-long
GiteaBot Apr 26, 2023
571cce4
Merge branch 'main' into remove-date-fmt-long
GiteaBot Apr 26, 2023
648b5b3
Merge branch 'main' into remove-date-fmt-long
GiteaBot Apr 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions modules/templates/helper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,9 +141,6 @@ func NewFuncMap() []template.FuncMap {
"TimeSinceUnix": timeutil.TimeSinceUnix,
"DateTime": timeutil.DateTime,
"Sec2Time": util.SecToTime,
"DateFmtLong": func(t time.Time) string {
return t.Format(time.RFC3339)
},
"LoadTimes": func(startTime time.Time) string {
return fmt.Sprint(time.Since(startTime).Nanoseconds()/1e6) + "ms"
},
Expand Down
2 changes: 1 addition & 1 deletion templates/admin/cron.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<td><button type="submit" class="ui green button" name="op" value="{{.Name}}" title="{{$.locale.Tr "admin.dashboard.operation_run"}}">{{svg "octicon-triangle-right"}}</button></td>
<td>{{$.locale.Tr (printf "admin.dashboard.%s" .Name)}}</td>
<td>{{.Spec}}</td>
<td>{{DateTime "full" (DateFmtLong .Next)}}</td>
<td>{{DateTime "full" .Next}}</td>
<td>{{if gt .Prev.Year 1}}{{DateTime "full" .Prev}}{{else}}N/A{{end}}</td>
<td>{{.ExecTimes}}</td>
<td {{if ne .Status ""}}data-tooltip-content="{{.FormatLastMessage $.locale}}"{{end}} >{{if eq .Status ""}}—{{else if eq .Status "finished"}}{{svg "octicon-check" 16}}{{else}}{{svg "octicon-x" 16}}{{end}}</td>
Expand Down