Skip to content

Changelog for v1.20.0-rc2 #25474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 27, 2023
Merged

Changelog for v1.20.0-rc2 #25474

merged 7 commits into from
Jun 27, 2023

Conversation

6543
Copy link
Member

@6543 6543 commented Jun 23, 2023

as title

@GiteaBot GiteaBot added this to the 1.20.0 milestone Jun 23, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 23, 2023
@6543 6543 added type/docs This PR mainly updates/creates documentation skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jun 23, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 23, 2023
@silverwind
Copy link
Member

Shouldn't we put changelog entries only for actual release, not release canidates?

@6543
Copy link
Member Author

6543 commented Jun 23, 2023

Shouldn't we put changelog entries only for actual release, not release canidates?

eg. https://github.com/go-gitea/gitea/releases/tag/v1.19.0-rc0
https://discord.com/channels/322538954119184384/1087684132697550918/1121821586434048083

6543
6543 commented Jun 23, 2023
View reviewed changes
6543
6543 commented Jun 23, 2023
View reviewed changes
6543
6543 commented Jun 23, 2023
View reviewed changes
6543
6543 commented Jun 23, 2023
View reviewed changes
@wxiaoguang
Copy link
Contributor

Sorry for bothering and apologize for my mistake .... could it defer after #25488 and #25484 then release rc2 ? 🙏

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 26, 2023
@richmahn
Copy link
Contributor

I had to review this changelog for my company since we will be going from 1.17.4 to 1.20.0, so very crucial I know al the changes. This helped to see (along with previous release notes), so that was my review, to make sure it was clear and useful.

@lunny
Copy link
Member

lunny commented Jun 26, 2023

We should change it to rc2 now.

@6543
Copy link
Member Author

6543 commented Jun 27, 2023

updated :)

techknowlogick
techknowlogick reviewed Jun 27, 2023
View reviewed changes
@lunny lunny changed the title Changelog for v1.20.0-rc1 Changelog for v1.20.0-rc2 Jun 27, 2023
@lunny lunny merged commit 6c43b9f into go-gitea:release/v1.20 Jun 27, 2023
@6543 6543 deleted the changelog_v20 branch June 27, 2023 13:07
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick left review comments

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

@richmahn richmahn richmahn approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
7 participants
@6543 @silverwind @wxiaoguang @richmahn @lunny @techknowlogick @GiteaBot