Skip to content

Revert "Make buttons in a modal form have proper type. (#25446) (#25478)" #25484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2023

Conversation

wxiaoguang
Copy link
Contributor

There is a side effect because some modal doesn't have a proper "ok" button.

This reverts commit 050c38c.

@GiteaBot GiteaBot added this to the 1.20.0 milestone Jun 24, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 24, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 24, 2023
This was referenced Jun 24, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 24, 2023
@6543 6543 enabled auto-merge (squash) June 24, 2023 13:08
@6543 6543 merged commit d1f1f11 into go-gitea:release/v1.20 Jun 24, 2023
@wxiaoguang wxiaoguang deleted the revert-modal-backport branch June 24, 2023 13:51
@6543 6543 added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jun 27, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants