-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Remove jQuery class from the commit button #30178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
silverwind
merged 5 commits into
go-gitea:main
from
yardenshoham:repo-editor-jquery-class
Mar 29, 2024
Merged
Remove jQuery class from the commit button #30178
silverwind
merged 5 commits into
go-gitea:main
from
yardenshoham:repo-editor-jquery-class
Mar 29, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Switched from jQuery class functions to plain JavaScript `classList` - Tested the commit button disabled toggling functionality and it works as before Signed-off-by: Yarden Shoham <[email protected]>
silverwind
reviewed
Mar 29, 2024
silverwind
approved these changes
Mar 29, 2024
silverwind
reviewed
Mar 29, 2024
silverwind
reviewed
Mar 29, 2024
delvh
approved these changes
Mar 29, 2024
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 30, 2024
* giteaofficial/main: Include encoding in signature payload (go-gitea#30174) Add `stylelint-value-no-unknown-custom-properties` and convert stylelint config to js (go-gitea#30117) Remove jQuery class from the commit button (go-gitea#30178) Remove jQuery class from the diff view (go-gitea#30176) Remove jQuery class from the notification count (go-gitea#30172) Remove jQuery class from the code range selection (go-gitea#30173) Fix:the rounded corners of the folded file are not displayed correctly (go-gitea#29953) Add setting to disable user features when user login type is not plain (go-gitea#29615) # Conflicts: # models/user/user.go
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
modifies/js
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
classList