cmd/link: bring back R_ARM_V4BX for Annapurna AL-212 and possibly others #44998

RustyDust · 2021-03-14T17:26:32Z

When trying to upgrade Go from 1.15.8 to 1.16 on my Netgear ReadyNAS RN204 and
it's Annapurna AL-212 ARM chip I ran into a compile time error:

$ cd src
go-go1.16.2/$ cd src
go-go1.16.2/src$ ./make.bash
Building Go cmd/dist using /usr/lib/go-1.15. (go1.15.8 linux/arm)
Building Go toolchain1 using /usr/lib/go-1.16.
Building Go bootstrap cmd/go (go_bootstrap) using Go toolchain1.
Building Go toolchain2 using go_bootstrap and Go toolchain1.
Building Go toolchain3 using go_bootstrap and Go toolchain2.
Building packages and commands for linux/arm.
net(.text): unexpected relocation type 296 (R_ARM_V4BX)
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x115a84]

Inspection of the changes showed that the code for handling R_ARM_V4BX that
was included in 1.15.x is mossing from 1.16 onwards. Since R_ARM_v4BX is
essentially a no-op accoring to the comment in the 1.15 tree I thought it
safe to just let it do that.

Using the patch I was able to build a working go 1.16.2, run the test suite
and build some apps for testing.

However, with me lacking deeper understanding of the code I have no idea
about possible side effects or whether there's an easier way to handle
this. So I'd be more than happy if someone with more knowledge could give
this a look.

Fixes #45012

When trying to upgrade Go from 1.15.8 to 1.16 on my Netgear ReadyNAS RN204 and it's Annapurna AL-212 ARM chip I ran into a compile time error: $ cd src go-go1.16.2/$ cd src go-go1.16.2/src$ ./make.bash Building Go cmd/dist using /usr/lib/go-1.15. (go1.15.8 linux/arm) Building Go toolchain1 using /usr/lib/go-1.16. Building Go bootstrap cmd/go (go_bootstrap) using Go toolchain1. Building Go toolchain2 using go_bootstrap and Go toolchain1. Building Go toolchain3 using go_bootstrap and Go toolchain2. Building packages and commands for linux/arm. net(.text): unexpected relocation type 296 (R_ARM_V4BX) panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x115a84] Inspection of the changes showed that the code for handling R_ARM_V4BX that was included in 1.15.x is mossing from 1.16 onwards. Since R_ARM_v4BX is essentially a no-op accoring to the comment in the 1.15 tree I thought it safe to just let it do that. Using the patch I was able to build a working go 1.16.2, run the test suite and build some apps for testing. However, with me lacking deeper understanding of the code I have no idea about possible side effects or whether there's an easier way to handle this. So I'd be more than happy if someone with more knowledge could give this a look.

google-cla · 2021-03-14T17:26:35Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

When trying to upgrade Go from 1.15.8 to 1.16 on my Netgear ReadyNAS RN204 and it's Annapurna AL-212 ARM chip I ran into a compile time error: $ cd src go-go1.16.2/$ cd src go-go1.16.2/src$ ./make.bash Building Go cmd/dist using /usr/lib/go-1.15. (go1.15.8 linux/arm) Building Go toolchain1 using /usr/lib/go-1.16. Building Go bootstrap cmd/go (go_bootstrap) using Go toolchain1. Building Go toolchain2 using go_bootstrap and Go toolchain1. Building Go toolchain3 using go_bootstrap and Go toolchain2. Building packages and commands for linux/arm. net(.text): unexpected relocation type 296 (R_ARM_V4BX) panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x115a84] Inspection of the changes showed that the code for handling R_ARM_V4BX that was included in 1.15.x is mossing from 1.16 onwards. Since R_ARM_v4BX is essentially a no-op accoring to the comment in the 1.15 tree I thought it safe to just let it do that. Using the patch I was able to build a working go 1.16.2, run the test suite and build some apps for testing. However, with me lacking deeper understanding of the code I have no idea about possible side effects or whether there's an easier way to handle this. So I'd be more than happy if someone with more knowledge could give this a look.

…bring_back_R_ARM_V4BX

google-cla · 2021-03-14T17:34:51Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

RustyDust · 2021-03-14T17:38:15Z

@googlebot I fixed it.

gopherbot · 2021-03-14T17:40:44Z

This PR (HEAD: 51ad391) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/301631 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-03-14T17:44:20Z

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://golang.org/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/301631.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-15T04:28:06Z

Message from Matthew Dempsky:

Patch Set 1: Run-TryBot+1 Trust+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/301631.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-15T04:28:07Z

Message from Go Bot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=5e2a61d9

Please don’t reply on this GitHub thread. Visit golang.org/cl/301631.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-15T04:46:13Z

Message from Go Bot:

Patch Set 1: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/301631.
After addressing review feedback, remember to publish your drafts!

When trying to upgrade Go from 1.15.8 to 1.16 on my Netgear ReadyNAS RN204 and it's Annapurna AL-212 ARM chip I ran into a compile time error: $ cd src go-go1.16.2/$ cd src go-go1.16.2/src$ ./make.bash Building Go cmd/dist using /usr/lib/go-1.15. (go1.15.8 linux/arm) Building Go toolchain1 using /usr/lib/go-1.16. Building Go bootstrap cmd/go (go_bootstrap) using Go toolchain1. Building Go toolchain2 using go_bootstrap and Go toolchain1. Building Go toolchain3 using go_bootstrap and Go toolchain2. Building packages and commands for linux/arm. net(.text): unexpected relocation type 296 (R_ARM_V4BX) panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x115a84] Inspection of the changes showed that the code for handling R_ARM_V4BX that was included in 1.15.x is mossing from 1.16 onwards. Since R_ARM_v4BX is essentially a no-op accoring to the comment in the 1.15 tree I thought it safe to just let it do that. Using the patch I was able to build a working go 1.16.2, run the test suite and build some apps for testing. However, with me lacking deeper understanding of the code I have no idea about possible side effects or whether there's an easier way to handle this. So I'd be more than happy if someone with more knowledge could give this a look. Fixes #45012

gopherbot · 2021-03-15T08:32:12Z

This PR (HEAD: 22f41ab) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/301631 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-11-08T11:28:57Z

Message from Matthew Dempsky:

Patch Set 1: Run-TryBot+1 Trust+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/301631.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:28:58Z

Message from Go Bot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=5e2a61d9

Please don’t reply on this GitHub thread. Visit golang.org/cl/301631.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:28:59Z

Message from Go Bot:

Patch Set 1: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/301631.
After addressing review feedback, remember to publish your drafts!

pazof

It really seams safe !

google-cla bot added the cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. label Mar 14, 2021

RustyDust added 2 commits March 14, 2021 18:32

Merge branch 'bring_back_R_ARM_V4BX' of github.com:RustyDust/go into …

51ad391

…bring_back_R_ARM_V4BX

google-cla bot added cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. and removed cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. labels Mar 14, 2021

RustyDust added 2 commits March 15, 2021 09:27

ianlancetaylor mentioned this pull request Nov 8, 2021

x/build/cmd/gerritbot: posts duplicate messages whenever Gerrit message IDs change #49467

Open

pazof reviewed Apr 11, 2023

View reviewed changes

RustyDust closed this by deleting the head repository Jun 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

cmd/link: bring back R_ARM_V4BX for Annapurna AL-212 and possibly others #44998

cmd/link: bring back R_ARM_V4BX for Annapurna AL-212 and possibly others #44998

Uh oh!

RustyDust commented Mar 14, 2021 •

edited

Loading

Uh oh!

google-cla bot commented Mar 14, 2021

Uh oh!

google-cla bot commented Mar 14, 2021

Uh oh!

RustyDust commented Mar 14, 2021

Uh oh!

gopherbot commented Mar 14, 2021

Uh oh!

gopherbot commented Mar 14, 2021

Uh oh!

gopherbot commented Mar 15, 2021

Uh oh!

gopherbot commented Mar 15, 2021

Uh oh!

gopherbot commented Mar 15, 2021

Uh oh!

gopherbot commented Mar 15, 2021

Uh oh!

gopherbot commented Nov 8, 2021

Uh oh!

gopherbot commented Nov 8, 2021

Uh oh!

gopherbot commented Nov 8, 2021

Uh oh!

pazof left a comment

Uh oh!

Uh oh!

cmd/link: bring back R_ARM_V4BX for Annapurna AL-212 and possibly others #44998

cmd/link: bring back R_ARM_V4BX for Annapurna AL-212 and possibly others #44998

Uh oh!

Conversation

RustyDust commented Mar 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

google-cla bot commented Mar 14, 2021

Uh oh!

google-cla bot commented Mar 14, 2021

Uh oh!

RustyDust commented Mar 14, 2021

Uh oh!

gopherbot commented Mar 14, 2021

Uh oh!

gopherbot commented Mar 14, 2021

Uh oh!

gopherbot commented Mar 15, 2021

Uh oh!

gopherbot commented Mar 15, 2021

Uh oh!

gopherbot commented Mar 15, 2021

Uh oh!

gopherbot commented Mar 15, 2021

Uh oh!

gopherbot commented Nov 8, 2021

Uh oh!

gopherbot commented Nov 8, 2021

Uh oh!

gopherbot commented Nov 8, 2021

Uh oh!

pazof left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

RustyDust commented Mar 14, 2021 •

edited

Loading