Skip to content
This repository was archived by the owner on Dec 19, 2023. It is now read-only.

feat: integrate extended GraphQL scalars #525

Conversation

BlasiusSecundus
Copy link

No description provided.

@BlasiusSecundus BlasiusSecundus force-pushed the feature/extended-scalars-integration branch from 402140c to 291140c Compare February 1, 2021 21:06
@setchy
Copy link
Member

setchy commented Feb 1, 2021

Nice!

On a related note - there is an open PR to updated extended-scalars to use graphql-java:16.1
graphql-java/graphql-java-extended-scalars#33 - still waiting for a maintainer

@setchy
Copy link
Member

setchy commented Feb 1, 2021

@BlasiusSecundus
Copy link
Author

Thanks @setchy, updated to 16.0.0.

@BlasiusSecundus
Copy link
Author

That test failure, again, is related to the test subscription.

Testing getRemainingResponses > Should properly return remaining responses after the Subscription was stopped. FAILED
java.lang.AssertionError:
Expecting:
<[]>
to contain exactly (and in same order):
<[1L, 2L, 3L, 4L, 5L, 6L, 7L, 8L, 9L]>
but could not find the following elements:
<[1L, 2L, 3L, 4L, 5L, 6L, 7L, 8L, 9L]>
at com.graphql.spring.boot.test.GraphQLTestSubscriptionGetRemainingResponsesTest.shouldGetRemainingResponses(GraphQLTestSubscriptionGetRemainingResponsesTest.java:27)

@oliemansm oliemansm merged commit ceb2aad into graphql-java-kickstart:master Feb 2, 2021
@oliemansm oliemansm added this to the 11.1.0 milestone Feb 2, 2021
@BlasiusSecundus BlasiusSecundus deleted the feature/extended-scalars-integration branch June 22, 2021 18:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants