Skip to content

build: upgrade to GraphQL Java 16.1 #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2021
Merged

build: upgrade to GraphQL Java 16.1 #33

merged 1 commit into from
Feb 1, 2021

Conversation

aoudiamoncef
Copy link
Contributor

@aoudiamoncef aoudiamoncef commented Nov 30, 2020 •
edited
Loading

Hi @bbakerman @andimarek,

I'm waiting for your feedback

Thanks

@aoudiamoncef
Copy link
Contributor Author

Hi @setchy,
Please could you look at this PR.

Thanks

@setchy
Copy link
Contributor

setchy commented Jan 16, 2021

I don't have permissions for this project @aoudiamoncef, that will have to come from @bbakerman directly

@aoudiamoncef
Copy link
Contributor Author

aoudiamoncef commented Jan 16, 2021 •
edited
Loading

Maybe if @bbakerman gives you permissions on this side project, it could accelerate the process.

@aoudiamoncef
Copy link
Contributor Author

aoudiamoncef commented Jan 18, 2021 •
edited
Loading

Hi @Sounie

Please could you look at this PR. This is the last one

Thanks

Sounie
Sounie reviewed Jan 18, 2021
View reviewed changes
readme.md
>
> use 15.0.0 or above for graphql-java 15.x and above
>
> use 16.0.0 or above for graphql-java 16.x and above
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible, though the developers may choose to go with a slightly different version numbering - to avoid users picking up graphql-java 16.0

This is one of my first interactions with this project, so don't take my opinion has carrying any weight.

@setchy
Copy link
Contributor

setchy commented Jan 20, 2021

Maybe if @bbakerman gives you permissions on this side project, it could accelerate the process.

I'd be happy to help

@setchy setchy mentioned this pull request Jan 21, 2021
Closed
@setchy setchy mentioned this pull request Feb 1, 2021
Merged
@bbakerman
Copy link
Member

Sorry folks I have been away a lot of late - sorry for the delay

Thanks for this PR

@bbakerman bbakerman merged commit 5be0a1c into graphql-java:master Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sounie Sounie Sounie left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aoudiamoncef @setchy @bbakerman @Sounie