Skip to content

invalid automatic module name when used with Java modules #101

Closed
@AutomatedTester

Description

@AutomatedTester

Describe the bug
When building Selenium with latest we are getting an invalid Automatic-Module-Name: com.graphql-java in the manifest.

There are two problems with that:

  • The project is dataloader, not graphql itself.
  • Module names need to be valid package names, and a dash character isn’t allowed

The better name is probably something like com.graphql.dataloader or similar

To get around this you just need to update gradle config to do what the Gradle docs suggests

To Reproduce
Update https://github.com/SeleniumHQ/selenium/blob/e92b16f0832da62204bda5d01fbc430ec9401deb/java/maven_deps.bzl to latest.

And then run bazel build grid in a terminal

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions