Fix invalid Automatic-Module-Name #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks |
|
@bbakerman do you plan on doing a 3.1.1 release for this for folks upgrading to 17.x and using dataloader requiring 3.x? |
|
Please do release, this is breaking my (Bazel) build |
|
3.1.1 has been released |
lkorth
added a commit
to lkorth/graphql-java-extended-scalars
that referenced
this pull request
Jun 8, 2022
`-` is invalid in the `Automatic-Module-Name` Related PRs: graphql-java/java-dataloader#104, graphql-java/graphql-java#2423 Fixes graphql-java#60
This was referenced Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the smallest change and consistent with graphql-java/graphql-java#2423, however it may make more sense to change to
org.dataloaderto match the package being used.Fixes #101