Skip to content

fix StableDiffusionTensorRT super args error #6009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gujingit
Copy link
Contributor

@gujingit gujingit commented Dec 1, 2023

What does this PR do?

This PR makes requires_safety_checkera keyword argument so it doesn't collide with StableDiffusionPipeline.image_encoder in the parameter order.

Fixes # (issue)
Similar to the issue #5992

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@asfiyab-nvidia

@gujingit gujingit force-pushed the fix/stable_diffusion_tensorrt_supplying_wrong_args_to_super branch from 8d91d4a to 0e4f366 Compare December 1, 2023 03:49
Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition!

@patrickvonplaten
Copy link
Contributor

@asfiyab-nvidia can you check as well?

@asfiyab-nvidia
Copy link
Contributor

LGTM, approved. Thanks for the contribution @gujingit

@sayakpaul sayakpaul merged commit bf92e74 into huggingface:main Dec 4, 2023
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants