Skip to content

Add a proxy Matcher #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2025
Merged

Add a proxy Matcher #171

merged 1 commit into from
Apr 29, 2025

Conversation

seanmonstar
Copy link
Member

@seanmonstar seanmonstar mentioned this pull request Mar 4, 2025
Open
@seanmonstar
Copy link
Member Author

I think the Builder type needs more methods, and the ability to load from macOS and Windows system proxies (another optional cargo feature). The way I've been testing it can do enough is to see if I can replace the types in reqwest. Not the exact types, mind you. reqwest::Proxy will still be its own type, but it could use this Matcher internally.

@andrzejSulkowski andrzejSulkowski mentioned this pull request Mar 6, 2025
Closed
2 tasks
@seanmonstar seanmonstar force-pushed the proxy-env branch 3 times, most recently from 766a0d6 to 4419861 Compare April 25, 2025 19:21
@seanmonstar seanmonstar marked this pull request as ready for review April 25, 2025 19:33
@seanmonstar seanmonstar changed the title WIP: Add a proxy Matcher Add a proxy Matcher Apr 25, 2025
@seanmonstar
feat(client): add proxy::matcher utilities
f6e94ca 
A builder for configuring a matcher, as well as the ability to create
one from standard environment variables.
@seanmonstar
Copy link
Member Author

Tests added, docs updated, and I have a local branch of reqwest using this. I think it's ready.

@seanmonstar seanmonstar merged commit 6c29abb into master Apr 29, 2025
16 checks passed
@seanmonstar seanmonstar deleted the proxy-env branch April 29, 2025 17:34
@andrzejSulkowski andrzejSulkowski mentioned this pull request Apr 30, 2025
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@seanmonstar