feat(client): Add system proxy support for macOS #172
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
force-pushed
the
proxy-env
branch
5 times, most recently
from
f414b84 to
f6e94ca
Compare
|
Didn't mean for this to auto-close. I think it just did because the branch this was aimed at was merged. If you want to update it and point at master, I'd be happy to merge! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc hyperium/hyper#3850
continued work on PR Draft #171
Because the "system-proxies" introduced quite a few lines of code, I decided to split the matcher.rs into multiple files (
builder.rs,matcher.rs,no_proxy.rs,utils.rs)- [ ] Windows System ProxiesWindows System Proxies should be implemented by someone who is using Windows or has a VM to impl. and test the code.