Proxy Websocket subprotocols #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great, thanks! @xhochy Do you or anyone else feel its worthwhile to make the feature available by configuration too rather than only subclasses? I see no reason not to merge as-is though, and add the configuration ability later, if there's a need. |
|
What do you mean by "available by configuration"? The feature here is just a pass-through of a connection attribute through the proxy. |
|
Sorry, brain freeze. I shouldn't review patches on mobile. |
|
Thanks @ryanlovett! |
|
@ryanlovett @betatim Can you tag us a release? We see quite a lot issue reports popping up with this in combination with
This would help us a lot. |
This was referenced Mar 24, 2020
|
Done! v1.3.0 tagged and uploaded to pypi. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #179