Skip to content

[MRG] Update server proxy and rsession proxy #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2020

Conversation

betatim
Copy link
Member

@betatim betatim commented Apr 4, 2020

Both haven't been updated in a long time (~1yr) so we should refresh
them. This brings both to the latest commit in their repos.

Can anyone remember if there were big changes in either that would break things for users of repo2docker?

Both haven't been updated in a long time (~1yr) so we should refresh
them. This brings both to the latest commit in their repos.
@consideRatio
Copy link
Member

Can anyone remember if there were big changes in either that would break things for users of repo2docker?

I've not followed the changes for that long, I'm not sure, but I know there is no changelog available. But, thanks to @choldgraf's github-activity project, I present the results below from running:

github-activity --kind=pr -o prs.md jupyterhub/jupyter-server-proxy --since 7ac0125

7ac0125...master@{2020-04-04}

(full changelog)

Merged PRs

@betatim betatim force-pushed the update-server-proxy branch from 9d57c06 to 8b5b557 Compare April 4, 2020 16:43
@betatim
Copy link
Member Author

betatim commented Apr 4, 2020

@consideRatio can you make a new release and add 1.3.2 to https://github.com/jupyterhub/jupyter-server-proxy/releases? The reason I updated server proxy was to see if the increased timeout deals with jupyterhub/jupyter-server-proxy#146. It seems it does. At least I don't get an error locally any more. The timeout change hasn't been released yet though. (I am perfectly fine using a particular commit instead of a release though, so only make a new release if you have time.)

@consideRatio
Copy link
Member

consideRatio commented Apr 4, 2020

@betatim ok!

@ryanlovett @yuvipanda I'm making a new release of jupyter-server-proxy containing a single PR (jupyterhub/jupyter-server-proxy#183) that I consider a bugfix, so from 1.3.1 to 1.3.2. Guided by the principle in release.rst saying:

We should release early & often, following semver wherever possible.

UPDATE: Done, see https://pypi.org/project/jupyter-server-proxy/

@consideRatio consideRatio merged commit d366af9 into jupyterhub:master Apr 4, 2020
@betatim betatim deleted the update-server-proxy branch April 5, 2020 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants