This repository was archived by the owner on Jan 6, 2025. It is now read-only.
Pin serde_json in CI to maintain MSRV
#10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnull
force-pushed
the
2023-07-pin-serde-json
branch
3 times, most recently
from
222cc16 to
e1f53c3
Compare
The `serde_json` crate switched to Rust edition 2021 starting with v1.0.101, i.e., has MSRV of 1.56. It also requires `serde` v1.0.166 starting with v1.0.100. We therefore pin it to v1.0.99 in CI to fix our MSRV checks.
tnull
force-pushed
the
2023-07-pin-serde-json
branch
from
e1f53c3 to
bc1638f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
serde_jsoncrate switched to Rust edition 2021 starting with v1.0.101, i.e., has MSRV of 1.56. It also requiresserdev1.0.166 starting with v1.0.100.We therefore pin it to v1.0.99 in CI to fix our MSRV checks.