This repository was archived by the owner on Jan 6, 2025. It is now read-only.
take and hold a reference to ChannelManager #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI failure should be due to #10. Feel free to rebase this PR after it has been merged. |
johncantrell97
force-pushed
the
channel-manager
branch
2 times, most recently
from
34b60bc to
c513fa5
Compare
johncantrell97
force-pushed
the
channel-manager
branch
from
c513fa5 to
3b21d50
Compare
|
Rebased, thanks |
tnull
reviewed
Jul 18, 2023
tnull
approved these changes
Jul 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no real need for the LiquidityManager to actually hold the channel manager. Once LSPS1 and/or LSPS2 are landed we should remove the reference from LiquidityManager as the reference will just pass through to the constructors of the protocols.
Instead of putting the type constraints on just the
newmethod, this way is closer to what it will actually look like once theLiquidityManagerwill hold LSPS1/2 objects that have these same generics.