Jit channels clean #20

johncantrell97 · 2023-10-05T16:38:43Z

This implements LSPS2: JIT Channels on top of LSPS0 transport layer.

.github/workflows/build.yml

tnull · 2023-10-12T12:00:02Z

This needs a rebase.

tnull

Started a thorough pass, still have to take a closer look at message handler commit and following.

Cargo.toml

src/jit_channel/mod.rs

src/jit_channel/msgs.rs

src/jit_channel/event.rs

src/lib.rs

tnull · 2023-10-17T09:27:51Z

src/jit_channel/channel_manager.rs

+{
+	entropy_source: ES,
+	peer_manager: Mutex<Option<Arc<PeerManager<Descriptor, CM, RM, OM, L, CMH, NS>>>>,
+	channel_manager: Arc<ChannelManager<M, T, ES, NS, SP, F, R, L>>,


Since LDK 0.0.117, we can use the AChannelManager trait here now.

src/jit_channel/channel_manager.rs

src/jit_channel/scid_utils.rs

tnull

Completed the pass.

Looks pretty good to me, but I have yet to do another pass comparing the logic once more to the spec.

src/jit_channel/scid_utils.rs

src/utils.rs

src/jit_channel/channel_manager.rs

src/transport/message_handler.rs

src/jit_channel/channel_manager.rs

tnull · 2023-10-26T08:51:51Z

src/jit_channel/channel_manager.rs

@@ -377,6 +380,8 @@ pub struct JITChannelManager<
 	per_peer_state: RwLock<HashMap<PublicKey, Mutex<PeerState>>>,
 	peer_by_scid: RwLock<HashMap<u64, PublicKey>>,
 	promise_secret: [u8; 32],
+	min_payment_size_msat: u64,


Will probably need all of the config options, so might be worth holding a JitChannelConfig here?

tnull · 2023-10-30T11:19:06Z

src/jit_channel/msgs.rs

+}
+
+impl RawOpeningFeeParams {
+	pub(crate) fn into_opening_fee_params(self, promise_secret: &[u8; 32]) -> OpeningFeeParams {


Still would be nice to have this be a util method analogous to is_valid_opening_fee (could also DRY this one up then) to keep LSP-specific logic separate from the messaging/type serialization.

Happy to have that happen in a follow-up though.

Now tracking here: https://github.com/lightningdevkit/ldk-lsp-client/issues/30

tnull · 2023-10-30T11:23:30Z

Cargo.toml


 bitcoin = "0.29.0"

+chrono = { version = "0.4", default-features = false, features = ["std", "serde"] }


Seems we don't actually require full std here, alloc should be enough.

Now tracking here: #29 (comment)

tnull · 2023-10-30T11:40:22Z

src/transport/message_handler.rs

+}
+
+/// Configuration options for JIT channels.
+pub struct JITChannelsConfig {


This probably should be renamed OutboundJitChannelConfig or LSPS2OutboundChannelConfig and get moved to the jit_channel/lsps2 module.

Now tracking here #31

tnull

Alright. I had another look at the spec and poked around a bit more.

While nothing in particular stood out, we'll def. want want to increase our input validation, error handling and test coverage going forward, i.e., before this is deemed stable and usable in production.

I had some minor comments which however can be addressed as follow ups. To this end, and to generally track next steps, I now opened a bunch of issues.

That said, for now, I'm merging this first draft 🎉

tnull mentioned this pull request Oct 5, 2023

LSPS2: JIT Channels #11

Closed

tnull reviewed Oct 5, 2023

View reviewed changes

.github/workflows/build.yml Outdated Show resolved Hide resolved

johncantrell97 force-pushed the jit-channels-clean branch from 43102d9 to 5634d6e Compare October 5, 2023 20:04

johncantrell97 force-pushed the jit-channels-clean branch 2 times, most recently from f28ea02 to 00fa488 Compare October 12, 2023 14:43

tnull reviewed Oct 17, 2023

View reviewed changes

johncantrell97 added 7 commits October 18, 2023 10:57

update ldk to 117

9e33ddd

add LSPS2 messages

5a5c99e

add LSPS2 events

56601c7

add LSPS2 message handler

0c903f9

setup LSPS2 message handler in LiquidityManager

e3a6ee2

expose lsps2 api in LiquidityManager

1fbedb7

expose types to lib users

9c954cc

johncantrell97 force-pushed the jit-channels-clean branch 2 times, most recently from 301174e to dc72629 Compare October 19, 2023 16:28

fix review comments

7c18cb1

johncantrell97 force-pushed the jit-channels-clean branch 3 times, most recently from bf7e14b to 6291be8 Compare October 19, 2023 17:12

tnull mentioned this pull request Oct 20, 2023

Project structure / Naming conventions #1

Closed

johncantrell97 force-pushed the jit-channels-clean branch from 6291be8 to a334959 Compare October 20, 2023 14:15

disable default chrono features to remove wasm-bindgen dep

8a61a5e

johncantrell97 force-pushed the jit-channels-clean branch from a334959 to 8a61a5e Compare October 20, 2023 14:21

johncantrell97 added 3 commits October 20, 2023 10:33

add myself as an author

ae6fd6a

add version check to handling of buy request

b8c2157

move payment_size ranges to config and handle buy request validation

cc4f009

johncantrell97 force-pushed the jit-channels-clean branch from 8791c15 to 05ea541 Compare October 20, 2023 15:58

johncantrell97 commented Oct 20, 2023

View reviewed changes

src/jit_channel/channel_manager.rs Show resolved Hide resolved

johncantrell97 added 2 commits October 20, 2023 12:22

add valid_until check into is_valid_opening_fee_params

795a097

remove memchr pin

a3259cc

johncantrell97 force-pushed the jit-channels-clean branch 5 times, most recently from 278e730 to f03a1aa Compare October 21, 2023 01:27

johncantrell97 added 2 commits October 20, 2023 21:39

use SystemTime instead of chrono with clock to test validity

53d4a20

pin chrono 0.4.24

646d54f

johncantrell97 force-pushed the jit-channels-clean branch from f03a1aa to 646d54f Compare October 21, 2023 01:39

johncantrell97 mentioned this pull request Oct 24, 2023

Add MPP support to LSPS2 #22

Merged

tnull reviewed Oct 26, 2023

View reviewed changes

tnull reviewed Oct 30, 2023

View reviewed changes

tnull mentioned this pull request Oct 30, 2023

Project Restructuring: Move LSPS implementations to lspsX modules #34

Closed

tnull approved these changes Oct 30, 2023

View reviewed changes

tnull merged commit 40cc652 into lightningdevkit:main Oct 30, 2023

tnull mentioned this pull request Oct 30, 2023

Add missing error handling #26

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Jit channels clean #20

Jit channels clean #20

johncantrell97 commented Oct 5, 2023

tnull commented Oct 12, 2023

tnull left a comment

tnull Oct 17, 2023

tnull left a comment

tnull Oct 26, 2023

tnull Oct 30, 2023

tnull Oct 30, 2023

tnull Oct 30, 2023 •

edited

Loading

tnull Oct 30, 2023

tnull Oct 30, 2023

tnull Oct 30, 2023

tnull left a comment


		bitcoin = "0.29.0"

		chrono = { version = "0.4", default-features = false, features = ["std", "serde"] }

Jit channels clean #20

Jit channels clean #20

Conversation

johncantrell97 commented Oct 5, 2023

tnull commented Oct 12, 2023

tnull left a comment

Choose a reason for hiding this comment

tnull Oct 17, 2023

Choose a reason for hiding this comment

tnull left a comment

Choose a reason for hiding this comment

tnull Oct 26, 2023

Choose a reason for hiding this comment

tnull Oct 30, 2023

Choose a reason for hiding this comment

tnull Oct 30, 2023

Choose a reason for hiding this comment

tnull Oct 30, 2023 • edited Loading

Choose a reason for hiding this comment

tnull Oct 30, 2023

Choose a reason for hiding this comment

tnull Oct 30, 2023

Choose a reason for hiding this comment

tnull Oct 30, 2023

Choose a reason for hiding this comment

tnull left a comment

Choose a reason for hiding this comment

tnull Oct 30, 2023 •

edited

Loading