Skip to content
This repository was archived by the owner on Jan 6, 2025. It is now read-only.

Jit channels clean #20

Merged
merged 16 commits into from
Oct 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,19 +28,14 @@ jobs:
- name: Pin crates for MSRV
if: matrix.msrv
run: |
# Tokio MSRV on versions 1.17 through 1.26 is rustc 1.49. Above 1.26 MSRV is 1.56.
cargo update -p tokio --precise "1.14.1" --verbose
# The serde_json crate switched to Rust edition 2021 starting with v1.0.101, i.e., has MSRV of 1.56
cargo update -p serde_json --precise "1.0.99" --verbose
cargo update -p serde --precise "1.0.156" --verbose
# The quote crate switched to Rust edition 2021 starting with v1.0.31, i.e., has MSRV of 1.56
cargo update -p quote --precise "1.0.30" --verbose
# The proc-macro2 crate switched to Rust edition 2021 starting with v1.0.66, i.e., has MSRV of 1.56
cargo update -p proc-macro2 --precise "1.0.65" --verbose
# Sadly the log crate is always a dependency of tokio until 1.20, and has no reasonable MSRV guarantees
cargo update -p log --precise "0.4.18" --verbose
# The memchr crate switched to Rust edition 2021 starting with v2.6.0
cargo update -p memchr --precise "2.5.0" --verbose
cargo update -p chrono --precise "0.4.24" --verbose
- name: Cargo check
run: cargo check --release
- name: Check documentation
Expand Down
8 changes: 4 additions & 4 deletions Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
[package]
name = "ldk-lsp-client"
version = "0.1.0"
authors = ["Elias Rohrer <[email protected]>"]
authors = ["John Cantrell <[email protected]>", "Elias Rohrer <[email protected]>"]
edition = "2018"
description = "Types and primitives to integrate a spec-compliant LSP with an LDK-based node."

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
lightning = { version = "0.0.116", features = ["max_level_trace", "std"] }
lightning-invoice = "0.24.0"
lightning-net-tokio = "0.0.116"
lightning = { version = "0.0.117", default-features = false, features = ["max_level_trace", "std"] }
lightning-invoice = "0.25.0"

bitcoin = "0.29.0"

chrono = { version = "0.4", default-features = false, features = ["std", "serde"] }
Copy link
Collaborator

@tnull tnull Oct 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems we don't actually require full std here, alloc should be enough.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now tracking here: #29 (comment)

serde = { version = "1.0", default-features = false, features = ["derive", "alloc"] }
serde_json = "1.0"
2 changes: 1 addition & 1 deletion src/channel_request/mod.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// This file is Copyright its original authors, visible in version contror
// This file is Copyright its original authors, visible in version control
// history.
//
// This file is licensed under the Apache License, Version 2.0 <LICENSE-APACHE
Expand Down
13 changes: 9 additions & 4 deletions src/events.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,10 @@
//! by the end-user.
//!
//! Because we don't have a built-in runtime, it's up to the end-user to poll
//! [`crate::LiquidityManager::get_and_clear_pending_events()`] to receive events.

//! [`LiquidityManager::get_and_clear_pending_events`] to receive events.
//!
//! [`LiquidityManager::get_and_clear_pending_events`]: crate::LiquidityManager::get_and_clear_pending_events
use crate::jit_channel;
use std::collections::VecDeque;
use std::sync::{Condvar, Mutex};

Expand Down Expand Up @@ -53,6 +55,9 @@ impl EventQueue {
}
}

/// Event which you should probably take some action in response to.
/// An event which you should probably take some action in response to.
#[derive(Debug, Clone, PartialEq, Eq)]
pub enum Event {}
pub enum Event {
/// An LSPS2 (JIT Channel) protocol event.
LSPS2(jit_channel::LSPS2Event),
}
Loading