[Backlog] Peers

[julianknutsen]

Meta issue containing work items for the ln/peers module. Items are in rough priority order and will change over time.

Next Up
Decomposed items that are scoped enough for development. Contributors should first check outstanding PRs and in-progress work to make sure there are no dependencies.

Need Refinement
Ideas, general thoughts, maybe-one-days that are still under discussion, but are important to keep around. Typically, they still need a consensus or a design review before moving forward.

---

Out for Review

• PR (2/4) PeerManager Unit Tests and Refactoring  #692 Rewrite unit tests for peer_handler module

In Progress

Next Up

• [Peers] Add doc/transport_module.md
• [Peers] Tech Debt: disconnect_socket vs. socket_disconnected naming confusion
• [Peers] Tech Debt: Move Transport code to separate folder
• [Peers] Move ln/peers to peers/
• [Peers] Tech Debt: Rename node_id/their_node_id
• [Peers] Testing: Simplify unit tests of the event handling code
• [Peers] Testing: Simplify unit tests of the message handling code
• [Peers] Testing: Unit test PeerHolder
• [Peers] Feature: Send message contained in ErrorAction::DisconnectPeer
• [Peers] Feature: Add Channel/Node/Update forwarding
• [Peers] Feature: Implement optional message dropping in Message send path
• Rewrite peer_handler module documentation

Need Refinement

• DoS protection in PeerHandler
• [Peers] Tech Debt: Revisit InitialSyncState behavior and object relationships
• [Peers] Feature: More robust defense against byte-fragmentation attacks
• [Peers] Feature: BOLT1 MAY FAIL if pong bytes_len does not match
• [Peers] Handle DisconnectPeer error from route_handler in event handler path?

[ariard]

Extend unit test coverage frameworks once gossips are further integrated in peers code. See #736 (comment) for more information.