Skip to content

Cut 0.0.110 #1629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 26, 2022
Merged

Cut 0.0.110 #1629

merged 2 commits into from
Jul 26, 2022

Conversation

TheBlueMatt
Copy link
Collaborator

Still waiting on at least one more PR, and maybe more, so these will change, but draft release notes for 110.

@TheBlueMatt TheBlueMatt added this to the 0.0.110 milestone Jul 25, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2022

Codecov Report

Merging #1629 (e996b71) into main (b84b53a) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head e996b71 differs from pull request most recent head 807a1af. Consider uploading reports for the commit 807a1af to get more accurate results

@@            Coverage Diff             @@
##             main    #1629      +/-   ##
==========================================
+ Coverage   90.77%   90.78%   +0.01%     
==========================================
  Files          80       80              
  Lines       44763    44694      -69     
  Branches    44763    44694      -69     
==========================================
- Hits        40632    40577      -55     
+ Misses       4131     4117      -14     
Impacted Files Coverage Δ
lightning/src/chain/onchaintx.rs 93.98% <0.00%> (-0.93%) ⬇️
lightning/src/util/events.rs 39.25% <0.00%> (-0.25%) ⬇️
lightning/src/chain/channelmonitor.rs 91.02% <0.00%> (-0.02%) ⬇️
lightning/src/chain/chainmonitor.rs 97.96% <0.00%> (-0.02%) ⬇️
lightning/src/ln/functional_test_utils.rs 93.57% <0.00%> (-0.01%) ⬇️
lightning/src/ln/channel.rs 88.78% <0.00%> (-0.01%) ⬇️
lightning/src/chain/mod.rs 68.18% <0.00%> (ø)
lightning/src/ln/channelmanager.rs 85.13% <0.00%> (+<0.01%) ⬆️
lightning/src/ln/functional_tests.rs 96.87% <0.00%> (+0.06%) ⬆️
lightning-net-tokio/src/lib.rs 77.16% <0.00%> (+0.30%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b84b53a...807a1af. Read the comment docs.


## Bug Fixes
* Fixed a panic when deserializing `ChannelDetails` objects (#1588).
* When routing, channels are no longer fully saturated before MPP splits are
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, do we really consider saturating a bug?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dunno, I do? I mean its, like, obviously not gonna work, so we're just picking routes we know are bunk.

@TheBlueMatt TheBlueMatt marked this pull request as ready for review July 26, 2022 19:18
@TheBlueMatt
Copy link
Collaborator Author

I think we're ready to go on this!

dunxen
dunxen previously approved these changes Jul 26, 2022
Copy link
Contributor

@dunxen dunxen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog LGTM
(Not sure if anything else missing)

Copy link
Contributor

@wpaulino wpaulino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through all merged PRs since 109 to make sure nothing user-impacting was left out.

* A new `Event::HTLCHandlingFailed` has been added which provides visibility
into failures to forward/claim accepted HTLCs (#1403).
* Support has been added for DNS hostnames in the `NetAddress` type, see
[BOLT PR #911](https://github.com/lightning/bolts/pull/911) (#1553).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason we don't also provide a link for rust-lightning PRs?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm kinda meh on making the lines longer with stuff that isn't useful for plaintext users, is mostly the reason, but I guess we could.

Copy link
Contributor

@valentinewallace valentinewallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after squash!

lightning-invoice = { version = "0.17.0", path = "../lightning-invoice" }
lightning-persister = { version = "0.0.109", path = "../lightning-persister" }
lightning = { version = "0.0.110", path = "../lightning", features = ["_test_utils"] }
lightning-invoice = { version = "0.18.0", path = "../lightning-invoice" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a reason to increment the lightning-invoice version? Or do we always increment it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We always do, as otherwise you have a lightning-invoice that depends on a different version of lightning and you can't easily use both at the same time.

@TheBlueMatt
Copy link
Collaborator Author

Squashed without further changes.

@TheBlueMatt TheBlueMatt merged commit 36bffb5 into lightningdevkit:main Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants