-
Notifications
You must be signed in to change notification settings - Fork 407
Cut 0.0.110 #1629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cut 0.0.110 #1629
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1629 +/- ##
==========================================
+ Coverage 90.77% 90.78% +0.01%
==========================================
Files 80 80
Lines 44763 44694 -69
Branches 44763 44694 -69
==========================================
- Hits 40632 40577 -55
+ Misses 4131 4117 -14
Continue to review full report at Codecov.
|
|
||
## Bug Fixes | ||
* Fixed a panic when deserializing `ChannelDetails` objects (#1588). | ||
* When routing, channels are no longer fully saturated before MPP splits are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, do we really consider saturating a bug?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dunno, I do? I mean its, like, obviously not gonna work, so we're just picking routes we know are bunk.
I think we're ready to go on this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog LGTM
(Not sure if anything else missing)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went through all merged PRs since 109 to make sure nothing user-impacting was left out.
* A new `Event::HTLCHandlingFailed` has been added which provides visibility | ||
into failures to forward/claim accepted HTLCs (#1403). | ||
* Support has been added for DNS hostnames in the `NetAddress` type, see | ||
[BOLT PR #911](https://github.com/lightning/bolts/pull/911) (#1553). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason we don't also provide a link for rust-lightning
PRs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm kinda meh on making the lines longer with stuff that isn't useful for plaintext users, is mostly the reason, but I guess we could.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good after squash!
lightning-invoice = { version = "0.17.0", path = "../lightning-invoice" } | ||
lightning-persister = { version = "0.0.109", path = "../lightning-persister" } | ||
lightning = { version = "0.0.110", path = "../lightning", features = ["_test_utils"] } | ||
lightning-invoice = { version = "0.18.0", path = "../lightning-invoice" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there a reason to increment the lightning-invoice version? Or do we always increment it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We always do, as otherwise you have a lightning-invoice that depends on a different version of lightning and you can't easily use both at the same time.
Squashed without further changes. |
Still waiting on at least one more PR, and maybe more, so these will change, but draft release notes for 110.