Skip to content

Cut 0.0.110 #1629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 26, 2022
Merged

Cut 0.0.110 #1629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a22ba39
Add CHANGELOG entry for 0.0.110
TheBlueMatt Jul 25, 2022
e10dfe4
Bump crate versions to 0.0.110/invoice 0.18
TheBlueMatt Jul 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 57 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,60 @@
# 0.0.110 - 2022-XXX

## API Updates
* `ChannelManager::send_probe` and `Score::probe_{failed,successful}` have
been added to make probing more explicit, as well as new
`Event::Probe{Failed,Successful}` events (#1567).
* `ProbabilisticScoringParameters::banned_nodes` has been renamed
`manual_node_penalties` and changed to take msat penalties (#1592).
* Per-payment tracking of failed paths was added to enable configuration of
`ProbabilisticScoringParameters::considered_impossible_penalty_msat` (#1600)
* `ProbabilisticScoringParameters::base_penalty_amount_multiplier_msat` was
added to allow a penalty that is only amount-dependent (#1617).
* `ProbabilisticScoringParameters::amount_penalty_multiplier_msat` was renamed
`liquidity_penalty_amount_multiplier_msat` (#1617).
* A new `Event::HTLCHandlingFailed` has been added which provides visibility
into failures to forward/claim accepted HTLCs (#1403).
* Support has been added for DNS hostnames in the `NetAddress` type, see
[BOLT PR #911](https://github.com/lightning/bolts/pull/911) (#1553).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason we don't also provide a link for rust-lightning PRs?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm kinda meh on making the lines longer with stuff that isn't useful for plaintext users, is mostly the reason, but I guess we could.

* `GossipSync` now has `rapid`, `p2p`, and `none` constructors (#1618).
* `lightning-net-tokio` no longer requires types to be in `Arc`s (#1623).
* The `htlc_maximum_msat` field is now required in `ChannelUpdate` gossip
messages. In tests this rejects < 1% of channels (#1519).
* `ReadOnlyNetworkGraph::{channel,node}` have been added to query for
individual channel/node data, primarily for bindings users (#1543).
* `FeeEstimator` implementations are now wrapped internally to ensure values
below 253 sats/kW are never used (#1552).
* Route selection no longer attempts to randomize path selection. This is
unlikely to lead to a material change in the paths selected (#1610).

## Bug Fixes
* Fixed a panic when deserializing `ChannelDetails` objects (#1588).
* When routing, channels are no longer fully saturated before MPP splits are
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, do we really consider saturating a bug?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dunno, I do? I mean its, like, obviously not gonna work, so we're just picking routes we know are bunk.

generated, instead a configuration knob was added as
`PaymentParameters::max_channel_saturation_power_of_half` (#1605).
* Fixed a panic which occurred in `ProbabilisticScorer` when wallclock time
goes backwards across a restart (#1603).

## Serialization Compatibility
* All new fields are ignored by prior versions of LDK. All new fields are not
present when reading objects serialized by prior versions of LDK.
* Channel information written in the `NetworkGraph` which is missing
`htlc_maximum_msat` may be dropped on deserialization (#1519).
* Similarly, node information written in the `NetworkGraph` which contains an
invalid hostname may be dropped on deserialization (#1519).

In total, this release features 79 files changed, 2935 insertions, 1363
deletions in 52 commits from 9 authors, in alphabetical order:
* Duncan Dean
* Elias Rohrer
* Jeffrey Czyz
* Matt Corallo
* Max Fang
* Viktor Tigerström
* Willem Van Lint
* Wilmer Paulino
* jurvis

# 0.0.109 - 2022-07-01

## API Updates
Expand Down
12 changes: 6 additions & 6 deletions lightning-background-processor/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-background-processor"
version = "0.0.109"
version = "0.0.110"
authors = ["Valentine Wallace <[email protected]>"]
license = "MIT OR Apache-2.0"
repository = "http://github.com/lightningdevkit/rust-lightning"
Expand All @@ -15,10 +15,10 @@ rustdoc-args = ["--cfg", "docsrs"]

[dependencies]
bitcoin = "0.28.1"
lightning = { version = "0.0.109", path = "../lightning", features = ["std"] }
lightning-rapid-gossip-sync = { version = "0.0.109", path = "../lightning-rapid-gossip-sync" }
lightning = { version = "0.0.110", path = "../lightning", features = ["std"] }
lightning-rapid-gossip-sync = { version = "0.0.110", path = "../lightning-rapid-gossip-sync" }

[dev-dependencies]
lightning = { version = "0.0.109", path = "../lightning", features = ["_test_utils"] }
lightning-invoice = { version = "0.17.0", path = "../lightning-invoice" }
lightning-persister = { version = "0.0.109", path = "../lightning-persister" }
lightning = { version = "0.0.110", path = "../lightning", features = ["_test_utils"] }
lightning-invoice = { version = "0.18.0", path = "../lightning-invoice" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a reason to increment the lightning-invoice version? Or do we always increment it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We always do, as otherwise you have a lightning-invoice that depends on a different version of lightning and you can't easily use both at the same time.

lightning-persister = { version = "0.0.110", path = "../lightning-persister" }
4 changes: 2 additions & 2 deletions lightning-block-sync/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-block-sync"
version = "0.0.109"
version = "0.0.110"
authors = ["Jeffrey Czyz", "Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "http://github.com/lightningdevkit/rust-lightning"
Expand All @@ -19,7 +19,7 @@ rpc-client = [ "serde", "serde_json", "chunked_transfer" ]

[dependencies]
bitcoin = "0.28.1"
lightning = { version = "0.0.109", path = "../lightning" }
lightning = { version = "0.0.110", path = "../lightning" }
futures = { version = "0.3" }
tokio = { version = "1.0", features = [ "io-util", "net", "time" ], optional = true }
serde = { version = "1.0", features = ["derive"], optional = true }
Expand Down
6 changes: 3 additions & 3 deletions lightning-invoice/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[package]
name = "lightning-invoice"
description = "Data structures to parse and serialize BOLT11 lightning invoices"
version = "0.17.0"
version = "0.18.0"
authors = ["Sebastian Geisler <[email protected]>"]
documentation = "https://docs.rs/lightning-invoice/"
license = "MIT OR Apache-2.0"
Expand All @@ -20,7 +20,7 @@ std = ["bitcoin_hashes/std", "num-traits/std", "lightning/std", "bech32/std"]

[dependencies]
bech32 = { version = "0.8", default-features = false }
lightning = { version = "0.0.109", path = "../lightning", default-features = false }
lightning = { version = "0.0.110", path = "../lightning", default-features = false }
secp256k1 = { version = "0.22", default-features = false, features = ["recovery", "alloc"] }
num-traits = { version = "0.2.8", default-features = false }
bitcoin_hashes = { version = "0.10", default-features = false }
Expand All @@ -29,6 +29,6 @@ core2 = { version = "0.3.0", default-features = false, optional = true }
serde = { version = "1.0.118", optional = true }

[dev-dependencies]
lightning = { version = "0.0.109", path = "../lightning", default-features = false, features = ["_test_utils"] }
lightning = { version = "0.0.110", path = "../lightning", default-features = false, features = ["_test_utils"] }
hex = "0.4"
serde_json = { version = "1"}
4 changes: 2 additions & 2 deletions lightning-net-tokio/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-net-tokio"
version = "0.0.109"
version = "0.0.110"
authors = ["Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand All @@ -16,7 +16,7 @@ rustdoc-args = ["--cfg", "docsrs"]

[dependencies]
bitcoin = "0.28.1"
lightning = { version = "0.0.109", path = "../lightning" }
lightning = { version = "0.0.110", path = "../lightning" }
tokio = { version = "1.0", features = [ "io-util", "macros", "rt", "sync", "net", "time" ] }

[dev-dependencies]
Expand Down
6 changes: 3 additions & 3 deletions lightning-persister/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-persister"
version = "0.0.109"
version = "0.0.110"
authors = ["Valentine Wallace", "Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand All @@ -17,11 +17,11 @@ _bench_unstable = ["lightning/_bench_unstable"]

[dependencies]
bitcoin = "0.28.1"
lightning = { version = "0.0.109", path = "../lightning" }
lightning = { version = "0.0.110", path = "../lightning" }
libc = "0.2"

[target.'cfg(windows)'.dependencies]
winapi = { version = "0.3", features = ["winbase"] }

[dev-dependencies]
lightning = { version = "0.0.109", path = "../lightning", features = ["_test_utils"] }
lightning = { version = "0.0.110", path = "../lightning", features = ["_test_utils"] }
6 changes: 3 additions & 3 deletions lightning-rapid-gossip-sync/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-rapid-gossip-sync"
version = "0.0.109"
version = "0.0.110"
authors = ["Arik Sosman <[email protected]>"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand All @@ -13,8 +13,8 @@ Utility to process gossip routing data from Rapid Gossip Sync Server.
_bench_unstable = []

[dependencies]
lightning = { version = "0.0.109", path = "../lightning" }
lightning = { version = "0.0.110", path = "../lightning" }
bitcoin = { version = "0.28.1", default-features = false }

[dev-dependencies]
lightning = { version = "0.0.109", path = "../lightning", features = ["_test_utils"] }
lightning = { version = "0.0.110", path = "../lightning", features = ["_test_utils"] }
2 changes: 1 addition & 1 deletion lightning/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning"
version = "0.0.109"
version = "0.0.110"
authors = ["Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand Down