Cut 0.0.111 #1712

TheBlueMatt · 2022-09-09T19:04:57Z

No description provided.

CHANGELOG.md

valentinewallace · 2022-09-09T19:13:27Z

CHANGELOG.md

+ * HTLCs which fail prior to being sent over their first hop are now marked as
+   retryable via `!PaymentPathFailed::payment_failed_permanently` (#1702).
+ * Dust HTLCs are now considered failed in the payment tracking logic after the
+   commitment transaction confirms, allowing retry on restart (#1691).


Are ChannelMonitors safe to remove now?

I think so now that #1466, #1620, and #1691 are addressed, unless @TheBlueMatt knows of another edge case. In any case, we may want to expose a public helper that users can call instead of relying on the result of get_claimable_balances.

Yes, I believe so. I don't want to announce it quite yet, though, would rather let the code sit for a release or two and then announce it.

valentinewallace · 2022-09-09T19:18:25Z

Wondering how people check if any PRs are missing? Maybe we should start tagging all PRs with the release milestone on merge if they aren't tagged already

ariard · 2022-09-09T19:20:03Z

Wondering how people check if any PRs are missing? Maybe we should start tagging all PRs with the release milestone on merge if they aren't tagged already

Usually with git log from the latest milestone and checking the diff. As iirc we don't care about really minor PRs to be mentioned, so we can't automate things

wpaulino · 2022-09-09T19:20:58Z

Wondering how people check if any PRs are missing?

My go-to is git log --merges v0.0.110..HEAD.

valentinewallace · 2022-09-09T19:22:21Z

git log --merges v0.0.110..HEAD

Super handy, thanks!

tnull · 2022-09-09T19:26:05Z

CHANGELOG.md

+   to avoid delaying other messages (#1604. #1660, #1683).
+ * Rather than spawning a full OS thread, `lightning-background-processor` has
+   a new `process_events_async` method which takes the place of a
+   `BackgroundProcessor` for those using Rust async (#1657).


Suggested change

`BackgroundProcessor` for those using Rust async (#1657).

`BackgroundProcessor` for those using Rust's `async` (#1657).

"async" isn't a name? Its a programming paradigm, I don't think it needs `s

CHANGELOG.md

valentinewallace

Lgtm after outstanding feedback

CHANGELOG.md

jkczyz · 2022-09-09T19:44:59Z

CHANGELOG.md

+
+## Backwards Compatibility
+ * The new `current_time` argument to `PeerManager` constructors must be set to
+   a UNIX timestamp for upgraded nodes. Only new nodes may use a counter (#1699)


nit: end with period

I didn't want to put it on a whole new line just for a "." 😭 I dropped the "Only".

CHANGELOG.md

ariard

List of PRs SGTM

ariard · 2022-09-09T20:10:40Z

CHANGELOG.md

+ * Dust HTLCs are now considered failed in the payment tracking logic after the
+   commitment transaction confirms, allowing retry on restart (#1691).
+ * On machines with buggy "monotonic" clocks, LDK will no longer panic if time
+   goes backwards (#1692).


I don't know if #1659 should be added or to minor.

See #1712 (comment)

codecov-commenter · 2022-09-09T21:07:21Z

Codecov Report

Merging #1712 (f5473d5) into main (990e346) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1712   +/-   ##
=======================================
  Coverage   90.80%   90.80%           
=======================================
  Files          86       86           
  Lines       46482    46482           
  Branches    46482    46482           
=======================================
+ Hits        42208    42210    +2     
+ Misses       4274     4272    -2

Impacted Files	Coverage Δ
lightning/src/ln/monitor_tests.rs	`99.44% <0.00%> (-0.12%)`	⬇️
lightning/src/ln/functional_tests.rs	`96.81% <0.00%> (-0.02%)`	⬇️
lightning/src/ln/channelmanager.rs	`85.00% <0.00%> (+0.02%)`	⬆️
lightning/src/chain/onchaintx.rs	`94.71% <0.00%> (+0.68%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

TheBlueMatt · 2022-09-09T21:54:04Z

Rebased on #1710 and filled in all the stats. This should be good to go once #1710 lands (shouldn't have to rebase it either if there's no changes there - the extra merge commit won't change the stats and I calculated them again #1710).

TheBlueMatt · 2022-09-11T16:58:16Z

Now based on #1714 with the CHANGELOG stats fixed and one extra entry for it.

TheBlueMatt · 2022-09-12T20:58:11Z

Okay, hopefully the last CHANGELOG update, fixed the stats again.

TheBlueMatt · 2022-09-12T21:10:01Z

Squashed, the relevant changes are:

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 83c13d9d3..df326abab 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -33,2 +33,3 @@
  * `Invoice` now derives the std `Hash` trait (#1575).
+ * `{Signed,}RawInvoice::hash` have been renamed `signable_hash` (#1714).
  * `chain::AccessError` now derives the std `Debug` trait (#1709).
@@ -78,4 +79,4 @@ in deployments creating outbound 0conf channels.
 
-In total, this release features 82 files changed, 6227 insertions, 1949
-deletions in 115 commits from 11 authors, in alphabetical order:
+In total, this release features 84 files changed, 6306 insertions, 1960
+deletions in 121 commits from 11 authors, in alphabetical order:
  * Arik Sosman

CHANGELOG.md

TheBlueMatt · 2022-09-12T22:34:10Z

Oops, right, addressed feedback. Note that I switched the date format up cause 9/12 is ambiguous, should probably do that for old dates too but for now I just changed the latest date.

TheBlueMatt · 2022-09-12T22:34:52Z

$ git diff-tree -U1 ee49030c f5473d50
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 71817b5e9..7736ce67e 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,2 +1,2 @@
-# 0.0.111 - 2022-09-09 - "Saturated with Messages"
+# 0.0.111 - Sep 12, 2022 - "Saturated with Messages"
 
@@ -17,4 +17,4 @@
    very difficult to correctly implement (i.e., without blocking). Users
-   previously using it should instead pass dependent transactions in via new
-   `chain::Confirm::transactions_confirmed` calls (#1663).
+   previously using it should instead pass dependent transactions in via
+   additional `chain::Confirm::transactions_confirmed` calls (#1663).
  * `ChannelHandshakeConfig::their_channel_reserve_proportional_millionths` has
@@ -60,5 +60,5 @@
  * The new `current_time` argument to `PeerManager` constructors must be set to
-   a UNIX timestamp for upgraded nodes, new nodes may use a counter (#1699).
+   a UNIX timestamp for upgraded nodes; new nodes may use a counter (#1699).
  * `Balance::CounterpartyRevokedOutputClaimable` will never be generated for
-   channels which were observed to go on-chain with LDK versions prior to
+   channels that were observed to go on-chain with LDK versions prior to
    0.0.111 (#1495).

TheBlueMatt added this to the 0.0.111 milestone Sep 9, 2022

valentinewallace reviewed Sep 9, 2022

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

valentinewallace reviewed Sep 9, 2022

View reviewed changes

tnull reviewed Sep 9, 2022

View reviewed changes

valentinewallace reviewed Sep 9, 2022

View reviewed changes

CHANGELOG.md Show resolved Hide resolved

valentinewallace reviewed Sep 9, 2022

View reviewed changes

CHANGELOG.md Show resolved Hide resolved

jkczyz reviewed Sep 9, 2022

View reviewed changes

ariard reviewed Sep 9, 2022

View reviewed changes

CHANGELOG.md Show resolved Hide resolved

ariard reviewed Sep 9, 2022

View reviewed changes

TheBlueMatt force-pushed the 2022-09-111 branch 2 times, most recently from 7e90cbc to e54a795 Compare September 9, 2022 20:20

TheBlueMatt force-pushed the 2022-09-111 branch from e54a795 to 309b239 Compare September 9, 2022 21:53

jkczyz previously approved these changes Sep 9, 2022

View reviewed changes

ariard previously approved these changes Sep 9, 2022

View reviewed changes

TheBlueMatt dismissed stale reviews from ariard and jkczyz via c3f5d51 September 11, 2022 16:58

TheBlueMatt force-pushed the 2022-09-111 branch from 309b239 to c3f5d51 Compare September 11, 2022 16:58

TheBlueMatt force-pushed the 2022-09-111 branch from c3f5d51 to fb6e869 Compare September 12, 2022 20:57

TheBlueMatt force-pushed the 2022-09-111 branch from fb6e869 to ede5175 Compare September 12, 2022 21:09

TheBlueMatt force-pushed the 2022-09-111 branch from ede5175 to ee49030 Compare September 12, 2022 21:11

valentinewallace previously approved these changes Sep 12, 2022

View reviewed changes

jkczyz previously approved these changes Sep 12, 2022

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

CHANGELOG.md Outdated Show resolved Hide resolved

CHANGELOG.md Outdated Show resolved Hide resolved

CHANGELOG.md Outdated Show resolved Hide resolved

Update release notes for 0.0.111

27e3464

TheBlueMatt dismissed stale reviews from jkczyz and valentinewallace via 1531697 September 12, 2022 22:33

TheBlueMatt force-pushed the 2022-09-111 branch from ee49030 to 1531697 Compare September 12, 2022 22:33

Bump versions to lightning* 0.0.111 and lightning-invoice 0.19

f5473d5

TheBlueMatt force-pushed the 2022-09-111 branch from 1531697 to f5473d5 Compare September 12, 2022 22:34

jkczyz approved these changes Sep 12, 2022

View reviewed changes

valentinewallace approved these changes Sep 12, 2022

View reviewed changes

TheBlueMatt merged commit 4ae65e8 into lightningdevkit:main Sep 13, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cut 0.0.111 #1712

Cut 0.0.111 #1712

TheBlueMatt commented Sep 9, 2022

valentinewallace Sep 9, 2022

wpaulino Sep 9, 2022

TheBlueMatt Sep 9, 2022

valentinewallace commented Sep 9, 2022

ariard commented Sep 9, 2022

wpaulino commented Sep 9, 2022

valentinewallace commented Sep 9, 2022

tnull Sep 9, 2022

TheBlueMatt Sep 9, 2022

valentinewallace left a comment

jkczyz Sep 9, 2022

TheBlueMatt Sep 9, 2022

ariard left a comment

ariard Sep 9, 2022

TheBlueMatt Sep 9, 2022

codecov-commenter commented Sep 9, 2022 •

edited

Loading

TheBlueMatt commented Sep 9, 2022

TheBlueMatt commented Sep 11, 2022

TheBlueMatt commented Sep 12, 2022

TheBlueMatt commented Sep 12, 2022 •

edited

Loading

TheBlueMatt commented Sep 12, 2022

TheBlueMatt commented Sep 12, 2022

	`BackgroundProcessor` for those using Rust async (#1657).
	`BackgroundProcessor` for those using Rust's `async` (#1657).

Cut 0.0.111 #1712

Cut 0.0.111 #1712

Conversation

TheBlueMatt commented Sep 9, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

valentinewallace commented Sep 9, 2022

ariard commented Sep 9, 2022

wpaulino commented Sep 9, 2022

valentinewallace commented Sep 9, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

valentinewallace left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ariard left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-commenter commented Sep 9, 2022 • edited Loading

Codecov Report

TheBlueMatt commented Sep 9, 2022

TheBlueMatt commented Sep 11, 2022

TheBlueMatt commented Sep 12, 2022

TheBlueMatt commented Sep 12, 2022 • edited Loading

TheBlueMatt commented Sep 12, 2022

TheBlueMatt commented Sep 12, 2022

codecov-commenter commented Sep 9, 2022 •

edited

Loading

TheBlueMatt commented Sep 12, 2022 •

edited

Loading