-
Notifications
You must be signed in to change notification settings - Fork 404
Fix several compile warnings added in some of my recent commits #1710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix several compile warnings added in some of my recent commits #1710
Conversation
I see another warning in |
Lol, what a dumb warning, |
Codecov Report
@@ Coverage Diff @@
## main #1710 +/- ##
==========================================
- Coverage 90.84% 90.83% -0.01%
==========================================
Files 86 86
Lines 46399 46398 -1
Branches 46399 46398 -1
==========================================
- Hits 42150 42145 -5
- Misses 4249 4253 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait to merge this until we have all 0.0.111 items completed so we can rebase and make sure no other warnings slip in?
b97d7cb
to
b84aa87
Compare
Rebased on all the 111 changes. Should be good to go now. |
There are a few more on the stable & beta
|
Oops, looks like half of those were introduced when I fixed other issues. For some reason the no-std warnings aren't reproducing locally so i was relying on CI. |
I'm just gonna leave the InitFeatures one for #1707, its test-only anyway. |
042b62b
042b62b
to
93291f9
Compare
93291f9
to
0cc3572
Compare
No description provided.