Skip to content

Cut 0.0.113 #1917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 16, 2022
Merged

Cut 0.0.113 #1917

merged 3 commits into from
Dec 16, 2022

Conversation

TheBlueMatt
Copy link
Collaborator

No description provided.

@TheBlueMatt TheBlueMatt added this to the 0.0.113 milestone Dec 14, 2022
@arik-so
Copy link
Contributor

arik-so commented Dec 14, 2022

"Workflow completed with no jobs" but there are no merge conflicts. Anything we can do to actually make Github run its actions?

@TheBlueMatt
Copy link
Collaborator Author

I kicked it.

@arik-so
Copy link
Contributor

arik-so commented Dec 14, 2022

Hm, doesn't appear to have done much.

@TheBlueMatt
Copy link
Collaborator Author

Ah, the actions change was actually incorrect.

arik-so
arik-so previously approved these changes Dec 14, 2022
@TheBlueMatt
Copy link
Collaborator Author

Updated stats with #1918

Copy link
Contributor

@ViktorTigerstrom ViktorTigerstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)! Mostly non blocking suggestions from my part. I realize that my added suggestions would need to take the char limit line break into account if you decide to use them, which they currently don't.

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2022

Codecov Report

Base: 90.75% // Head: 90.75% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (2802cc3) compared to base (40b78ea).
Patch has no changes to coverable lines.

❗ Current head 2802cc3 differs from pull request most recent head f96ac1d. Consider uploading reports for the commit f96ac1d to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1917   +/-   ##
=======================================
  Coverage   90.75%   90.75%           
=======================================
  Files          94       94           
  Lines       49603    49603           
  Branches    49603    49603           
=======================================
+ Hits        45015    45018    +3     
+ Misses       4588     4585    -3     
Impacted Files Coverage Δ
lightning/src/chain/onchaintx.rs 95.17% <0.00%> (-0.21%) ⬇️
lightning/src/chain/channelmonitor.rs 90.90% <0.00%> (-0.10%) ⬇️
lightning/src/ln/functional_tests.rs 97.07% <0.00%> (+0.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dunxen
Copy link
Contributor

dunxen commented Dec 15, 2022

LGTM after pending comments.

arik-so
arik-so previously approved these changes Dec 15, 2022
@arik-so
Copy link
Contributor

arik-so commented Dec 15, 2022

Could you squash?

Copy link
Contributor

@wpaulino wpaulino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after squash

@TheBlueMatt
Copy link
Collaborator Author

Squashed without change.

@arik-so arik-so merged commit f6a9382 into lightningdevkit:main Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants