-
Notifications
You must be signed in to change notification settings - Fork 404
Cut 0.0.113 #1917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cut 0.0.113 #1917
Conversation
a83dbb9
to
c802bbd
Compare
"Workflow completed with no jobs" but there are no merge conflicts. Anything we can do to actually make Github run its actions? |
I kicked it. |
c802bbd
to
a4abcae
Compare
Hm, doesn't appear to have done much. |
a4abcae
to
a1965a5
Compare
Ah, the actions change was actually incorrect. |
a1965a5
to
7b07415
Compare
Updated stats with #1918 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :)! Mostly non blocking suggestions from my part. I realize that my added suggestions would need to take the char limit line break into account if you decide to use them, which they currently don't.
Codecov ReportBase: 90.75% // Head: 90.75% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1917 +/- ##
=======================================
Coverage 90.75% 90.75%
=======================================
Files 94 94
Lines 49603 49603
Branches 49603 49603
=======================================
+ Hits 45015 45018 +3
+ Misses 4588 4585 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
LGTM after pending comments. |
7b07415
to
2802cc3
Compare
Could you squash? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after squash
2802cc3
to
f96ac1d
Compare
Squashed without change. |
No description provided.