Unify blinding nomenclature to call them "paths" not "routes". #1918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the `onion_message` module exposes the blinded route object as *both* `BlindedRoute` and `BlindedPath`. This is somewhat confusing, and given they are really paths, not routes (at least in the sense that a route could be multi-path, though for OMs they are not), here we unify to only call them paths.
TheBlueMatt
force-pushed
the
2022-12-one-blinded-path
branch
from
bba6e90 to
cbb63f6
Compare
Following up on the previous commit, this also renames variables and the module used to `blinded_path`.
Finishing the work from the previous two commits.
TheBlueMatt
force-pushed
the
2022-12-one-blinded-path
branch
from
cbb63f6 to
8dbf6db
Compare
valentinewallace
approved these changes
Dec 14, 2022
jkczyz
approved these changes
Dec 14, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
onion_messagemodule exposes the blinded route object as bothBlindedRouteandBlindedPath. This is somewhat confusing, and given they are really paths, not routes (at least in the sense that a route could be multi-path, though for OMs they are not), here we unify to only call them paths.