Use env::temp_dir() for BP tests
#2234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `BackgroundProcessor` tests create persister directories in the current working directory and rely on cleaning up in a `Drop` implementation. Unfortunately, it seems that in the async tests that nodes are not `drop()`ed for some reason and so the directories created by those tests remain behind in the current working directory. This commit at least ensures that these test directories are created in a temporary location for the OS using `temp_dir()`. It doesn't aim to solve the lack of cleanup in the async tests. Partial fix for lightningdevkit#2224 but I believe it's enough to resolve it as these temp directories that do remain will be purged by the OS at some stage and are overwritten by subsequent tests if there is a conflict.
wpaulino
approved these changes
Apr 26, 2023
TheBlueMatt
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
BackgroundProcessortests create persister directories in the current working directory and rely on cleaning up in aDropimplementation.Unfortunately, it seems that in the async tests that nodes are not
drop()ed for some reason and so the directories created by those tests remain behind in the current working directory.This commit at least ensures that these test directories are created in a temporary location for the OS using
temp_dir(). It doesn't aim to solve the lack of cleanup in the async tests.Partial fix for #2224, but I believe it's enough to resolve it as these temp directories that do remain will be purged by the OS at some stage and are overwritten by subsequent tests if there is a conflict.