Skip to content

Re-export RouteHint and PaymentSecret #2572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 14, 2023
Merged

Re-export RouteHint and PaymentSecret #2572

merged 1 commit into from
Sep 14, 2023

Conversation

benthecarman
Copy link
Contributor

Some projects that use lightning_invoice to construct invoices need to use lightning purely to have access to RouteHint and PaymentSecret. Re-exporting should make it simpler

G8XSU
G8XSU reviewed Sep 12, 2023
View reviewed changes
@benthecarman benthecarman force-pushed the rexport-route-hint-secret branch from 9136044 to 1d3c254 Compare September 13, 2023 01:34
TheBlueMatt
TheBlueMatt previously approved these changes Sep 13, 2023
View reviewed changes
@benthecarman benthecarman force-pushed the rexport-route-hint-secret branch from 1d3c254 to 79b426f Compare September 14, 2023 17:41
@TheBlueMatt TheBlueMatt merged commit 51d5ead into lightningdevkit:main Sep 14, 2023
ErikDeSmedt added a commit to ErikDeSmedt/rust-lightning that referenced this pull request Sep 19, 2023
@ErikDeSmedt
Reexport RouteHintHop
a7e2fe2 
Earlier @benthecarman re-exported `RouteHint` to make life-easier
for developpers that use `lightning-invoice` and don't use the
`lightning`-crate.

This only solved part of the issue. To create a `RouteHint` the
developer must also have access to `RouteHintHop`.

See also:
  PR lightningdevkit#2572
	commit 79b426f
@ErikDeSmedt ErikDeSmedt mentioned this pull request Sep 19, 2023
Merged
ErikDeSmedt added a commit to ErikDeSmedt/rust-lightning that referenced this pull request Sep 19, 2023
@ErikDeSmedt
Reexport RouteHintHop
b771f08 
Earlier @benthecarman re-exported `RouteHint` to make life-easier
for developpers that use `lightning-invoice` and don't use the
`lightning`-crate.

This only solved part of the issue. To create a `RouteHint` the
developer must also have access to `RouteHintHop`.

See also:
  PR lightningdevkit#2572
	commit 79b426f
ErikDeSmedt added a commit to ErikDeSmedt/rust-lightning that referenced this pull request Sep 20, 2023
@ErikDeSmedt
Reexport RouteHintHop
22e81e0 
Earlier @benthecarman re-exported `RouteHint` to make life-easier
for developpers that use `lightning-invoice` and don't use the
`lightning`-crate.

This only solved part of the issue. To create a `RouteHint` the
developer must also have access to `RouteHintHop`.

See also:
  PR lightningdevkit#2572
	commit 79b426f
ErikDeSmedt added a commit to ErikDeSmedt/rust-lightning that referenced this pull request Sep 20, 2023
@ErikDeSmedt
Reexport RouteHintHop
a9f0ae2 
Earlier @benthecarman re-exported `RouteHint` to make life-easier
for developpers that use `lightning-invoice` and don't use the
`lightning`-crate.

This only solved part of the issue. To create a `RouteHint` the
developer must also have access to `RouteHintHop`.

See also:
  PR lightningdevkit#2572
	commit 79b426f
ErikDeSmedt added a commit to ErikDeSmedt/rust-lightning that referenced this pull request Sep 20, 2023
@ErikDeSmedt
Reexport RouteHintHop
eb59e1b 
Earlier @benthecarman re-exported `RouteHint` to make life-easier
for developpers that use `lightning-invoice` and don't use the
`lightning`-crate.

This only solved part of the issue. To create a `RouteHint` the
developer must also have access to `RouteHintHop`.

See also:
  PR lightningdevkit#2572
	commit 79b426f
ErikDeSmedt added a commit to ErikDeSmedt/rust-lightning that referenced this pull request Sep 20, 2023
@ErikDeSmedt
Reexport RouteHintHop
fde30c3 
Earlier @benthecarman re-exported `RouteHint` to make life-easier
for developpers that use `lightning-invoice` and don't use the
`lightning`-crate.

This only solved part of the issue. To create a `RouteHint` the
developer must also have access to `RouteHintHop`.

See also:
  PR lightningdevkit#2572
	commit 79b426f
ErikDeSmedt added a commit to ErikDeSmedt/rust-lightning that referenced this pull request Sep 21, 2023
@ErikDeSmedt
Reexport RouteHintHop
d1d23ff 
Earlier @benthecarman re-exported `RouteHint` to make life-easier
for developpers that use `lightning-invoice` and don't use the
`lightning`-crate.

This only solved part of the issue. To create a `RouteHint` the
developer must also have access to `RouteHintHop`.

See also:
  PR lightningdevkit#2572
	commit 79b426f
dunxen pushed a commit to dunxen/rust-lightning that referenced this pull request Sep 26, 2023
@ErikDeSmedt @dunxen
Reexport RouteHintHop
ea8346e 
Earlier @benthecarman re-exported `RouteHint` to make life-easier
for developpers that use `lightning-invoice` and don't use the
`lightning`-crate.

This only solved part of the issue. To create a `RouteHint` the
developer must also have access to `RouteHintHop`.

See also:
  PR lightningdevkit#2572
	commit 79b426f
slanesuke pushed a commit to slanesuke/rust-lightning that referenced this pull request Oct 6, 2023
@ErikDeSmedt @slanesuke
Reexport RouteHintHop
f6675e0 
Earlier @benthecarman re-exported `RouteHint` to make life-easier
for developpers that use `lightning-invoice` and don't use the
`lightning`-crate.

This only solved part of the issue. To create a `RouteHint` the
developer must also have access to `RouteHintHop`.

See also:
  PR lightningdevkit#2572
	commit 79b426f
optout21 pushed a commit to optout21/rust-lightning that referenced this pull request Nov 4, 2023
@ErikDeSmedt @optout21
Reexport RouteHintHop
1b0b3af 
Earlier @benthecarman re-exported `RouteHint` to make life-easier
for developpers that use `lightning-invoice` and don't use the
`lightning`-crate.

This only solved part of the issue. To create a `RouteHint` the
developer must also have access to `RouteHintHop`.

See also:
  PR lightningdevkit#2572
	commit 79b426f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnull tnull tnull approved these changes

@TheBlueMatt TheBlueMatt TheBlueMatt approved these changes

@G8XSU G8XSU G8XSU approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benthecarman @tnull @TheBlueMatt @G8XSU