Reexport RouteHintHop #2589
Merged
Reexport RouteHintHop #2589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch! Looking more thoroughly you might need to add |
ErikDeSmedt
force-pushed
the
reexport_route_hint_hop
branch
from
a7e2fe2 to
b771f08
Compare
|
Thanks, I've included the import as well |
|
Looks like CI is failing, |
ErikDeSmedt
force-pushed
the
reexport_route_hint_hop
branch
from
b771f08 to
22e81e0
Compare
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2589 +/- ##
==========================================
- Coverage 88.85% 88.76% -0.10%
==========================================
Files 113 113
Lines 84463 84534 +71
Branches 84463 84534 +71
==========================================
- Hits 75053 75040 -13
- Misses 7188 7259 +71
- Partials 2222 2235 +13
☔ View full report in Codecov by Sentry. |
ErikDeSmedt
force-pushed
the
reexport_route_hint_hop
branch
from
22e81e0 to
a9f0ae2
Compare
tnull
reviewed
Sep 20, 2023
ErikDeSmedt
force-pushed
the
reexport_route_hint_hop
branch
from
a9f0ae2 to
eb59e1b
Compare
benthecarman
requested changes
Sep 20, 2023
ErikDeSmedt
force-pushed
the
reexport_route_hint_hop
branch
from
eb59e1b to
fde30c3
Compare
Earlier @benthecarman re-exported `RouteHint` to make life-easier for developpers that use `lightning-invoice` and don't use the `lightning`-crate. This only solved part of the issue. To create a `RouteHint` the developer must also have access to `RouteHintHop`. See also: PR lightningdevkit#2572 commit 79b426f
ErikDeSmedt
force-pushed
the
reexport_route_hint_hop
branch
from
fde30c3 to
d1d23ff
Compare
benthecarman
approved these changes
Sep 21, 2023
TheBlueMatt
approved these changes
Sep 21, 2023
tnull
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier @benthecarman re-exported
RouteHintto make life-easier for developpers who uselightning-invoiceand don't use thelightning-crate.This only solved part of the issue. To create a
RouteHintthe developer must also have access toRouteHintHop.See also:
PR #2572
commit 79b426f