Issue in adding rust lightning as dependency on windows

[DhananjayPurohit]

I am having issue in adding rust-llightning as dependency on my windows machine. On debugging, I found this submodule icon inside /lightning-invoice/src:-

The file lightning-invoice/src/time_utils.rs contains symbolic link to /lightning/src/util/time.rs which is followed fine on unix and darwin but not on windows.

It appears that lightning-invoice/src/time_utils.rs is no longer needed. I have tried fixing that in this PR.

@ariard

[tnull]

I think you can just enable symbolic link support when installing Git for Windows. You'll then want to set

git config --global core.symlinks true

after which you should be able to checkout rust-lightning just fine.

[G8XSU]

Ok, but this change looks good to go right ?
Can you squash all commits into 1 commit with proper commit message and description.

[tnull]

Ok, but this change looks good to go right ? Can you squash all commits into 1 commit with proper commit message and description.

Not sure, not too long ago @TheBlueMatt pushed back on removing the symlink: #2377.

[TheBlueMatt]

I'm not a fan of removing the symlink if we need the dup code, but we don't actually use time_utils in lightning-invoice anymore, so we should absolutely remove this! This LGTM, can you squash the commits down so they each build individually?

[codecov-commenter]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (3236be1) 90.34% compared to head (cf0cef8) 88.96%.
Report is 509 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2607      +/-   ##
==========================================
- Coverage   90.34%   88.96%   -1.39%     
==========================================
  Files         106      112       +6     
  Lines       55093    86199   +31106     
  Branches    55093    86199   +31106     
==========================================
+ Hits        49773    76683   +26910     
- Misses       5320     7285    +1965     
- Partials        0     2231    +2231     

Files	Coverage Δ
lightning-invoice/src/lib.rs	85.23% <ø> (+6.06%)	⬆️

... and 115 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tnull]

LGTM