tests: Add sanity tests for ChannelOpens #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongcarl
force-pushed
the
2019-08-channel-open-sanity
branch
from
1be007b to
03d9944
Compare
Codecov Report
@@ Coverage Diff @@
## master #374 +/- ##
==========================================
+ Coverage 87.39% 87.48% +0.09%
==========================================
Files 29 29
Lines 15751 15775 +24
==========================================
+ Hits 13765 13801 +36
+ Misses 1986 1974 -12
Continue to review full report at Codecov.
|
TheBlueMatt
reviewed
Aug 2, 2019
|
|
||
| let open_channel_message = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id()); | ||
|
|
||
| let insane_open_helper = |expected_error_str, message_mutator: fn(msgs::OpenChannel) -> msgs::OpenChannel| { |
There was a problem hiding this comment.
You dont actually check this?
There was a problem hiding this comment.
expected_error_string, that is.
dongcarl
force-pushed
the
2019-08-channel-open-sanity
branch
from
03d9944 to
00410bf
Compare
|
@TheBlueMatt Let me know if the comments are inaccurate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.