[X86] Consistently use getVectorIdxConstant for element/subvector extract/insertion nodes. NFC. (#123312)

Avoid the use of getIntPtrConstant for anything other than address pointer related code.

Noticed while trying to use getVectorIdxConstant as a breakpoint.

Author: RKSimon