Skip to content

[RISCV] Fix InsnCI register type #100113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Conversation

svs-quic
Copy link
Contributor

@svs-quic svs-quic commented Jul 23, 2024

According to the spec the CI type instructions can take any of the 32 RVI registers.

Fixes #100112

@llvmbot llvmbot added backend:RISC-V mc Machine (object) code labels Jul 23, 2024
@llvmbot
Copy link
Member

llvmbot commented Jul 23, 2024

@llvm/pr-subscribers-backend-risc-v

@llvm/pr-subscribers-mc

Author: Sudharsan Veeravalli (svs-quic)

Changes

According to the spec the CI type instructions can take any of the 32 RVI registers.


Full diff: https://github.com/llvm/llvm-project/pull/100113.diff

2 Files Affected:

  • (modified) llvm/lib/Target/RISCV/RISCVInstrInfoC.td (+4-4)
  • (modified) llvm/test/MC/RISCV/insn_c.s (+10)
diff --git a/llvm/lib/Target/RISCV/RISCVInstrInfoC.td b/llvm/lib/Target/RISCV/RISCVInstrInfoC.td
index 9257ee5a09a8e..3f279b7a58ca6 100644
--- a/llvm/lib/Target/RISCV/RISCVInstrInfoC.td
+++ b/llvm/lib/Target/RISCV/RISCVInstrInfoC.td
@@ -764,9 +764,9 @@ def InsnCR : DirectiveInsnCR<(outs AnyReg:$rd), (ins uimm2_opcode:$opcode,
                                                      uimm4:$funct4,
                                                      AnyReg:$rs2),
                              "$opcode, $funct4, $rd, $rs2">;
-def InsnCI : DirectiveInsnCI<(outs AnyRegC:$rd), (ins uimm2_opcode:$opcode,
-                                                      uimm3:$funct3,
-                                                      simm6:$imm6),
+def InsnCI : DirectiveInsnCI<(outs AnyReg:$rd), (ins uimm2_opcode:$opcode,
+                                                     uimm3:$funct3,
+                                                     simm6:$imm6),
                              "$opcode, $funct3, $rd, $imm6">;
 def InsnCIW : DirectiveInsnCIW<(outs AnyRegC:$rd), (ins uimm2_opcode:$opcode,
                                                         uimm3:$funct3,
@@ -818,7 +818,7 @@ def : InstAlias<".insn_cr $opcode, $funct4, $rd, $rs2",
                 (InsnCR AnyReg:$rd, uimm2_opcode:$opcode, uimm4:$funct4,
                         AnyReg:$rs2)>;
 def : InstAlias<".insn_ci $opcode, $funct3, $rd, $imm6",
-                (InsnCI AnyRegC:$rd, uimm2_opcode:$opcode, uimm3:$funct3,
+                (InsnCI AnyReg:$rd, uimm2_opcode:$opcode, uimm3:$funct3,
                         simm6:$imm6)>;
 def : InstAlias<".insn_ciw $opcode, $funct3, $rd, $imm8",
                 (InsnCIW AnyRegC:$rd, uimm2_opcode:$opcode, uimm3:$funct3,
diff --git a/llvm/test/MC/RISCV/insn_c.s b/llvm/test/MC/RISCV/insn_c.s
index 19169e8b08c94..c63e8ab33aef9 100644
--- a/llvm/test/MC/RISCV/insn_c.s
+++ b/llvm/test/MC/RISCV/insn_c.s
@@ -31,6 +31,16 @@ target:
 # CHECK-OBJ: c.addi a0, 0xd
 .insn ci C1, 0, a0, 13
 
+# CHECK-ASM: .insn ci  1, 0, a6, 13
+# CHECK-ASM: encoding: [0x35,0x08]
+# CHECK-OBJ: c.addi a6, 0xd
+.insn ci  1, 0, a6, 13
+
+# CHECK-ASM: .insn ci  1, 0, a6, 13
+# CHECK-ASM: encoding: [0x35,0x08]
+# CHECK-OBJ: c.addi a6, 0xd
+.insn ci C1, 0, a6, 13
+
 # CHECK-ASM: .insn ciw  0, 0, a0, 13
 # CHECK-ASM: encoding: [0xa8,0x01]
 # CHECK-OBJ: c.addi4spn a0, sp, 0xc8

Copy link
Member

@lenary lenary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice catch. Please wait for another reviewer before merging though.

Copy link
Contributor

@wangpc-pp wangpc-pp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@svs-quic
Copy link
Contributor Author

Could someone please merge this? Thanks.

@wangpc-pp wangpc-pp merged commit 1ebfc81 into llvm:main Jul 23, 2024
10 checks passed
@svs-quic
Copy link
Contributor Author

Does this need to go into the 19.x release branch?

@wangpc-pp
Copy link
Contributor

/cherry-pick 1ebfc81

llvmbot pushed a commit to llvmbot/llvm-project that referenced this pull request Jul 24, 2024
According to the spec the CI type instructions can take any of the 32
RVI registers.

Fixes llvm#100112

(cherry picked from commit 1ebfc81)
@llvmbot
Copy link
Member

llvmbot commented Jul 24, 2024

/pull-request #100306

lenary pushed a commit to llvmbot/llvm-project that referenced this pull request Jul 24, 2024
According to the spec the CI type instructions can take any of the 32
RVI registers.

Fixes llvm#100112

(cherry picked from commit 1ebfc81)
tru pushed a commit to llvmbot/llvm-project that referenced this pull request Jul 24, 2024
According to the spec the CI type instructions can take any of the 32
RVI registers.

Fixes llvm#100112

(cherry picked from commit 1ebfc81)
yuxuanchen1997 pushed a commit that referenced this pull request Jul 25, 2024
Summary:
According to the spec the CI type instructions can take any of the 32
RVI registers.

Fixes #100112

Test Plan: 

Reviewers: 

Subscribers: 

Tasks: 

Tags: 


Differential Revision: https://phabricator.intern.facebook.com/D60251158
@svs-quic svs-quic deleted the riscv-insnci-anyreg branch August 6, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

[RISCV] Incorrect definition of InsnCI
4 participants