-
Notifications
You must be signed in to change notification settings - Fork 13.6k
[Xtensa] Implement branch analysis. #110959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -185,3 +185,298 @@ void XtensaInstrInfo::loadImmediate(MachineBasicBlock &MBB, | |
report_fatal_error("Unsupported load immediate value"); | ||
} | ||
} | ||
|
||
bool XtensaInstrInfo::reverseBranchCondition( | ||
SmallVectorImpl<MachineOperand> &Cond) const { | ||
assert(Cond.size() <= 4 && "Invalid branch condition!"); | ||
|
||
switch (Cond[0].getImm()) { | ||
case Xtensa::BEQ: | ||
Cond[0].setImm(Xtensa::BNE); | ||
return false; | ||
case Xtensa::BNE: | ||
Cond[0].setImm(Xtensa::BEQ); | ||
return false; | ||
case Xtensa::BLT: | ||
Cond[0].setImm(Xtensa::BGE); | ||
return false; | ||
case Xtensa::BGE: | ||
Cond[0].setImm(Xtensa::BLT); | ||
return false; | ||
case Xtensa::BLTU: | ||
Cond[0].setImm(Xtensa::BGEU); | ||
return false; | ||
case Xtensa::BGEU: | ||
Cond[0].setImm(Xtensa::BLTU); | ||
return false; | ||
case Xtensa::BEQI: | ||
Cond[0].setImm(Xtensa::BNEI); | ||
return false; | ||
case Xtensa::BNEI: | ||
Cond[0].setImm(Xtensa::BEQI); | ||
return false; | ||
case Xtensa::BGEI: | ||
Cond[0].setImm(Xtensa::BLTI); | ||
return false; | ||
case Xtensa::BLTI: | ||
Cond[0].setImm(Xtensa::BGEI); | ||
return false; | ||
case Xtensa::BGEUI: | ||
Cond[0].setImm(Xtensa::BLTUI); | ||
return false; | ||
case Xtensa::BLTUI: | ||
Cond[0].setImm(Xtensa::BGEUI); | ||
return false; | ||
case Xtensa::BEQZ: | ||
Cond[0].setImm(Xtensa::BNEZ); | ||
return false; | ||
case Xtensa::BNEZ: | ||
Cond[0].setImm(Xtensa::BEQZ); | ||
return false; | ||
case Xtensa::BLTZ: | ||
Cond[0].setImm(Xtensa::BGEZ); | ||
return false; | ||
case Xtensa::BGEZ: | ||
Cond[0].setImm(Xtensa::BLTZ); | ||
return false; | ||
default: | ||
report_fatal_error("Invalid branch condition!"); | ||
} | ||
} | ||
|
||
bool XtensaInstrInfo::analyzeBranch(MachineBasicBlock &MBB, | ||
MachineBasicBlock *&TBB, | ||
MachineBasicBlock *&FBB, | ||
SmallVectorImpl<MachineOperand> &Cond, | ||
bool AllowModify = false) const { | ||
Comment on lines
+247
to
+251
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This family of functions should be implemented independently of branch relaxation. They're more used for branch folding There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thank you for comment. Is it ok if I will correct this PR and remove branch relaxation functionality? The PR then will contain only branch analysis implementation. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. sure There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Corrected |
||
// Most of the code and comments here are boilerplate. | ||
|
||
// Start from the bottom of the block and work up, examining the | ||
// terminator instructions. | ||
MachineBasicBlock::iterator I = MBB.end(); | ||
while (I != MBB.begin()) { | ||
--I; | ||
if (I->isDebugValue()) | ||
continue; | ||
Comment on lines
+259
to
+260
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Untested? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I prepared new test which checks analyzeBranch and reverseBranchCondition functionality. I hope I understand your comment correctly. |
||
|
||
// Working from the bottom, when we see a non-terminator instruction, we're | ||
// done. | ||
if (!isUnpredicatedTerminator(*I)) | ||
break; | ||
|
||
// A terminator that isn't a branch can't easily be handled by this | ||
// analysis. | ||
SmallVector<MachineOperand, 4> ThisCond; | ||
ThisCond.push_back(MachineOperand::CreateImm(0)); | ||
const MachineOperand *ThisTarget; | ||
if (!isBranch(I, ThisCond, ThisTarget)) | ||
return true; | ||
|
||
// Can't handle indirect branches. | ||
if (!ThisTarget->isMBB()) | ||
return true; | ||
|
||
if (ThisCond[0].getImm() == Xtensa::J) { | ||
// Handle unconditional branches. | ||
if (!AllowModify) { | ||
TBB = ThisTarget->getMBB(); | ||
continue; | ||
} | ||
|
||
// If the block has any instructions after a JMP, delete them. | ||
while (std::next(I) != MBB.end()) | ||
std::next(I)->eraseFromParent(); | ||
|
||
Cond.clear(); | ||
FBB = 0; | ||
|
||
// TBB is used to indicate the unconditinal destination. | ||
TBB = ThisTarget->getMBB(); | ||
continue; | ||
} | ||
|
||
// Working from the bottom, handle the first conditional branch. | ||
if (Cond.empty()) { | ||
// FIXME: add X86-style branch swap | ||
FBB = TBB; | ||
TBB = ThisTarget->getMBB(); | ||
Cond.push_back(MachineOperand::CreateImm(ThisCond[0].getImm())); | ||
|
||
// push remaining operands | ||
for (unsigned int i = 0; i < (I->getNumExplicitOperands() - 1); i++) | ||
Cond.push_back(I->getOperand(i)); | ||
|
||
continue; | ||
} | ||
|
||
// Handle subsequent conditional branches. | ||
assert(Cond.size() <= 4); | ||
assert(TBB); | ||
|
||
// Only handle the case where all conditional branches branch to the same | ||
// destination. | ||
if (TBB != ThisTarget->getMBB()) | ||
return true; | ||
|
||
// If the conditions are the same, we can leave them alone. | ||
unsigned OldCond = Cond[0].getImm(); | ||
if (OldCond == ThisCond[0].getImm()) | ||
continue; | ||
} | ||
|
||
return false; | ||
} | ||
|
||
unsigned XtensaInstrInfo::removeBranch(MachineBasicBlock &MBB, | ||
int *BytesRemoved) const { | ||
// Most of the code and comments here are boilerplate. | ||
MachineBasicBlock::iterator I = MBB.end(); | ||
unsigned Count = 0; | ||
if (BytesRemoved) | ||
*BytesRemoved = 0; | ||
|
||
while (I != MBB.begin()) { | ||
--I; | ||
SmallVector<MachineOperand, 4> Cond; | ||
Cond.push_back(MachineOperand::CreateImm(0)); | ||
const MachineOperand *Target; | ||
if (!isBranch(I, Cond, Target)) | ||
break; | ||
if (!Target->isMBB()) | ||
break; | ||
// Remove the branch. | ||
if (BytesRemoved) | ||
*BytesRemoved += getInstSizeInBytes(*I); | ||
I->eraseFromParent(); | ||
I = MBB.end(); | ||
++Count; | ||
} | ||
return Count; | ||
} | ||
|
||
unsigned XtensaInstrInfo::insertBranch( | ||
MachineBasicBlock &MBB, MachineBasicBlock *TBB, MachineBasicBlock *FBB, | ||
ArrayRef<MachineOperand> Cond, const DebugLoc &DL, int *BytesAdded) const { | ||
unsigned Count = 0; | ||
if (BytesAdded) | ||
*BytesAdded = 0; | ||
if (FBB) { | ||
// Need to build two branches then | ||
// one to branch to TBB on Cond | ||
// and a second one immediately after to unconditionally jump to FBB | ||
Count = insertBranchAtInst(MBB, MBB.end(), TBB, Cond, DL, BytesAdded); | ||
auto &MI = *BuildMI(&MBB, DL, get(Xtensa::J)).addMBB(FBB); | ||
Count++; | ||
if (BytesAdded) | ||
*BytesAdded += getInstSizeInBytes(MI); | ||
return Count; | ||
} | ||
// This function inserts the branch at the end of the MBB | ||
Count += insertBranchAtInst(MBB, MBB.end(), TBB, Cond, DL, BytesAdded); | ||
return Count; | ||
} | ||
|
||
unsigned XtensaInstrInfo::insertBranchAtInst(MachineBasicBlock &MBB, | ||
MachineBasicBlock::iterator I, | ||
MachineBasicBlock *TBB, | ||
ArrayRef<MachineOperand> Cond, | ||
const DebugLoc &DL, | ||
int *BytesAdded) const { | ||
// Shouldn't be a fall through. | ||
assert(TBB && "InsertBranch must not be told to insert a fallthrough"); | ||
assert(Cond.size() <= 4 && | ||
"Xtensa branch conditions have less than four components!"); | ||
|
||
if (Cond.empty() || (Cond[0].getImm() == Xtensa::J)) { | ||
// Unconditional branch | ||
MachineInstr *MI = BuildMI(MBB, I, DL, get(Xtensa::J)).addMBB(TBB); | ||
if (BytesAdded && MI) | ||
*BytesAdded += getInstSizeInBytes(*MI); | ||
return 1; | ||
} | ||
|
||
unsigned Count = 0; | ||
unsigned BR_C = Cond[0].getImm(); | ||
MachineInstr *MI = nullptr; | ||
switch (BR_C) { | ||
case Xtensa::BEQ: | ||
case Xtensa::BNE: | ||
case Xtensa::BLT: | ||
case Xtensa::BLTU: | ||
case Xtensa::BGE: | ||
case Xtensa::BGEU: | ||
MI = BuildMI(MBB, I, DL, get(BR_C)) | ||
.addReg(Cond[1].getReg()) | ||
.addReg(Cond[2].getReg()) | ||
.addMBB(TBB); | ||
break; | ||
case Xtensa::BEQI: | ||
case Xtensa::BNEI: | ||
case Xtensa::BLTI: | ||
case Xtensa::BLTUI: | ||
case Xtensa::BGEI: | ||
case Xtensa::BGEUI: | ||
MI = BuildMI(MBB, I, DL, get(BR_C)) | ||
.addReg(Cond[1].getReg()) | ||
.addImm(Cond[2].getImm()) | ||
.addMBB(TBB); | ||
break; | ||
case Xtensa::BEQZ: | ||
case Xtensa::BNEZ: | ||
case Xtensa::BLTZ: | ||
case Xtensa::BGEZ: | ||
MI = BuildMI(MBB, I, DL, get(BR_C)).addReg(Cond[1].getReg()).addMBB(TBB); | ||
break; | ||
default: | ||
report_fatal_error("Invalid branch type!"); | ||
} | ||
if (BytesAdded && MI) | ||
*BytesAdded += getInstSizeInBytes(*MI); | ||
++Count; | ||
return Count; | ||
} | ||
|
||
bool XtensaInstrInfo::isBranch(const MachineBasicBlock::iterator &MI, | ||
SmallVectorImpl<MachineOperand> &Cond, | ||
const MachineOperand *&Target) const { | ||
unsigned OpCode = MI->getOpcode(); | ||
switch (OpCode) { | ||
case Xtensa::J: | ||
case Xtensa::JX: | ||
case Xtensa::BR_JT: | ||
Cond[0].setImm(OpCode); | ||
Target = &MI->getOperand(0); | ||
return true; | ||
case Xtensa::BEQ: | ||
case Xtensa::BNE: | ||
case Xtensa::BLT: | ||
case Xtensa::BLTU: | ||
case Xtensa::BGE: | ||
case Xtensa::BGEU: | ||
Cond[0].setImm(OpCode); | ||
Target = &MI->getOperand(2); | ||
return true; | ||
|
||
case Xtensa::BEQI: | ||
case Xtensa::BNEI: | ||
case Xtensa::BLTI: | ||
case Xtensa::BLTUI: | ||
case Xtensa::BGEI: | ||
case Xtensa::BGEUI: | ||
Cond[0].setImm(OpCode); | ||
Target = &MI->getOperand(2); | ||
return true; | ||
|
||
case Xtensa::BEQZ: | ||
case Xtensa::BNEZ: | ||
case Xtensa::BLTZ: | ||
case Xtensa::BGEZ: | ||
Cond[0].setImm(OpCode); | ||
Target = &MI->getOperand(1); | ||
return true; | ||
|
||
default: | ||
assert(!MI->getDesc().isBranch() && "Unknown branch opcode"); | ||
return false; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure all of these are tested?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested most of cases for reverseBranchCondition and it seems it works correctly.