[lldb][docs] Document Lua 5.3 as the only supported version #115288
Conversation
Technically you can manually set `LUA_LIBRARIES` and others to use a different version, and I don't see any version checks in the C++ code. However, I'm not sure that is intentional, it looks more like a side effect of how the CMake was written.
|
@llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) ChangesTechnically you can manually set Full diff: https://github.com/llvm/llvm-project/pull/115288.diff 1 Files Affected:
diff --git a/lldb/docs/resources/build.rst b/lldb/docs/resources/build.rst
index 33b6a6f79def4b..e64f71d0325382 100644
--- a/lldb/docs/resources/build.rst
+++ b/lldb/docs/resources/build.rst
@@ -64,7 +64,7 @@ CMake configuration error.
+-------------------+------------------------------------------------------+--------------------------+
| Python | Python scripting | ``LLDB_ENABLE_PYTHON`` |
+-------------------+------------------------------------------------------+--------------------------+
-| Lua | Lua scripting | ``LLDB_ENABLE_LUA`` |
+| Lua | Lua scripting. Only version 5.3 is supported. | ``LLDB_ENABLE_LUA`` |
+-------------------+------------------------------------------------------+--------------------------+
Depending on your platform and package manager, one might run any of the
|
There was a problem hiding this comment.
LGTM. Lua doesn't guarantee compatibility between minor version, so Lua 5.3 and 5.4 are more like Python 2 and Python 3 rather than Python 3.9 and 3.11 for example. I might try to get it working with both at some point (mostly because Homebrew install 5.4 by default and I have to do extra work to get [email protected]). Until then this matches the state of things.
|
Although Lua doesn't use semver, the difference between 5.3 and 5.4 isn't as stark as I thought. LLDB builds fine against Lua 5.4 and I was able to make the test pass. I just need to make a change so we don't hardcode |
|
Abandoning in favour of your patch, thanks! |
Technically you can manually set
LUA_LIBRARIESand others to use a different version, and I don't see any version checks in the C++ code. However, I'm not sure that is intentional, it looks more like a side effect of how the CMake was written.