AMDGPU: Add MC support for gfx950 V_BITOP3_B32/B16 #117379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 22, 2024
This was referenced Nov 22, 2024
Merged
This was referenced Nov 22, 2024
This was referenced Nov 26, 2024
Merged
Merged
mikaelholmen
reviewed
Dec 4, 2024
| return Res; | ||
| } | ||
|
|
||
| AMDGPUOperand::Ptr AMDGPUAsmParser::defaultBitOp3() const { |
There was a problem hiding this comment.
Hi,
This method seems to be unused on main. WIll it be used in some coming patch or should it be removed?
gcc warns like
../lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:9809: warning: '{anonymous}::AMDGPUOperand::Ptr {anonymous}::AMDGPUAsmParser::defaultBitOp3() const' defined but not used [-Wunused-function]
9809 | AMDGPUOperand::Ptr AMDGPUAsmParser::defaultBitOp3() const {
|
searlmc1
pushed a commit
to ROCm/llvm-project
that referenced
this pull request
Feb 3, 2025
Co-authored-by: Pravin Jagtap <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Pravin Jagtap [email protected]