[llvm][aarch64] fix copypaste typo

[klensy]

moved from #119881

cc @davemgreen

[llvmbot]

@llvm/pr-subscribers-backend-aarch64

Author: klensy (klensy)

Changes

moved from #119881

cc @davemgreen

---

Full diff: https://github.com/llvm/llvm-project/pull/120725.diff

1 Files Affected:

• (modified) llvm/lib/Target/AArch64/AArch64ISelLowering.cpp (+1-1)

diff --git a/llvm/lib/Target/AArch64/AArch64ISelLowering.cpp b/llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
index a27c030237c878..1dce6189f0c290 100644
--- a/llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
+++ b/llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
@@ -18396,7 +18396,7 @@ static SDValue performUADDVAddCombine(SDValue A, SelectionDAG &DAG) {
     EVT VT = A.getValueType();
     SDValue Op0 = A.getOperand(0);
     SDValue Op1 = A.getOperand(1);
-    if (Op0.getOpcode() != Op0.getOpcode() ||
+    if (Op0.getOpcode() != Op1.getOpcode() ||
         (Op0.getOpcode() != ISD::ZERO_EXTEND &&
          Op0.getOpcode() != ISD::SIGN_EXTEND))
       return SDValue();

[klensy]

Where should i put test from #119881 (comment) ? Somewhere at ./llvm/test/CodeGen/AArch64/?

[davemgreen]

Where should i put test from #119881 (comment) ? Somewhere at ./llvm/test/CodeGen/AArch64/?

Into llvm/test/CodeGen/AArch64/vecreduce-add.ll please. There is already a add_v4i32_v4i64_zext/add_v4i32_v4i64_sext, although they look a little different.

Thanks for doing this.

[davemgreen]

Thanks. LGTM

[davemgreen]

Should I hit submit and merge on this? I never know who has commit access themselves.

[klensy]

I don't have any rights anyway, so, up to you or other reviewer.

[davemgreen]

Lets do it. Thanks for noticing the issue and putting together a fix.