[MLIR][OpenMP] Add OMP Mapper field to MapInfoOp #120994

TIFitis · 2024-12-23T19:09:08Z

This patch adds the mapper field to the omp.map.info op.

Depends on #117046.

llvmbot · 2024-12-23T19:09:44Z

@llvm/pr-subscribers-flang-fir-hlfir

@llvm/pr-subscribers-flang-openmp

Author: Akash Banerjee (TIFitis)

Changes

This patch adds the mapper field to the omp.map.info op.

Full diff: https://github.com/llvm/llvm-project/pull/120994.diff

3 Files Affected:

(modified) mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td (+2)
(modified) mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp (+1-1)
(modified) mlir/test/Dialect/OpenMP/ops.mlir (+2-2)

diff --git a/mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td b/mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td
index 881f28d42e6312..7cc2c8fa8ce1e1 100644
--- a/mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td
+++ b/mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td
@@ -1000,6 +1000,7 @@ def MapInfoOp : OpenMP_Op<"map.info", [AttrSizedOperandSegments]> {
                        OptionalAttr<IndexListArrayAttr>:$members_index,
                        Variadic<OpenMP_MapBoundsType>:$bounds, /* rank-0 to rank-{n-1} */
                        OptionalAttr<UI64Attr>:$map_type,
+                       OptionalAttr<FlatSymbolRefAttr>:$mapper_id,
                        OptionalAttr<VariableCaptureKindAttr>:$map_capture_type,
                        OptionalAttr<StrAttr>:$name,
                        DefaultValuedAttr<BoolAttr, "false">:$partial_map);
@@ -1064,6 +1065,7 @@ def MapInfoOp : OpenMP_Op<"map.info", [AttrSizedOperandSegments]> {
     `var_ptr` `(` $var_ptr `:` type($var_ptr) `,` $var_type `)`
     oilist(
         `var_ptr_ptr` `(` $var_ptr_ptr `:` type($var_ptr_ptr) `)`
+      | `mapper` `(` $mapper_id `)`
       | `map_clauses` `(` custom<MapClause>($map_type) `)`
       | `capture` `(` custom<CaptureType>($map_capture_type) `)`
       | `members` `(` $members `:` custom<MembersIndex>($members_index) `:` type($members) `)`
diff --git a/mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp b/mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp
index b15d6ed15244ed..92233654ba1ddc 100644
--- a/mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp
+++ b/mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp
@@ -1592,7 +1592,7 @@ static LogicalResult verifyMapClause(Operation *op, OperandRange mapVars) {
 
         to ? updateToVars.insert(updateVar) : updateFromVars.insert(updateVar);
       }
-    } else {
+    } else if (!isa<DeclareMapperInfoOp>(op)) {
       emitError(op->getLoc(), "map argument is not a map entry operation");
     }
   }
diff --git a/mlir/test/Dialect/OpenMP/ops.mlir b/mlir/test/Dialect/OpenMP/ops.mlir
index a167c8bd1abbf9..97ef132f6dfa53 100644
--- a/mlir/test/Dialect/OpenMP/ops.mlir
+++ b/mlir/test/Dialect/OpenMP/ops.mlir
@@ -2523,13 +2523,13 @@ func.func @omp_targets_with_map_bounds(%arg0: !llvm.ptr, %arg1: !llvm.ptr) -> ()
   // CHECK: %[[C_12:.*]] = llvm.mlir.constant(2 : index) : i64
   // CHECK: %[[C_13:.*]] = llvm.mlir.constant(2 : index) : i64
   // CHECK: %[[BOUNDS1:.*]] = omp.map.bounds   lower_bound(%[[C_11]] : i64) upper_bound(%[[C_10]] : i64) stride(%[[C_12]] : i64) start_idx(%[[C_13]] : i64)
-  // CHECK: %[[MAP1:.*]] = omp.map.info var_ptr(%[[ARG1]] : !llvm.ptr, !llvm.array<10 x i32>)   map_clauses(exit_release_or_enter_alloc) capture(ByCopy) bounds(%[[BOUNDS1]]) -> !llvm.ptr {name = ""}
+  // CHECK: %[[MAP1:.*]] = omp.map.info var_ptr(%[[ARG1]] : !llvm.ptr, !llvm.array<10 x i32>)   mapper(@my_mapper) map_clauses(exit_release_or_enter_alloc) capture(ByCopy) bounds(%[[BOUNDS1]]) -> !llvm.ptr {name = ""}
     %6 = llvm.mlir.constant(9 : index) : i64
     %7 = llvm.mlir.constant(1 : index) : i64
     %8 = llvm.mlir.constant(2 : index) : i64
     %9 = llvm.mlir.constant(2 : index) : i64
     %10 = omp.map.bounds   lower_bound(%7 : i64) upper_bound(%6 : i64) stride(%8 : i64) start_idx(%9 : i64)
-    %mapv2 = omp.map.info var_ptr(%arg1 : !llvm.ptr, !llvm.array<10 x i32>)   map_clauses(exit_release_or_enter_alloc) capture(ByCopy) bounds(%10) -> !llvm.ptr {name = ""}
+    %mapv2 = omp.map.info var_ptr(%arg1 : !llvm.ptr, !llvm.array<10 x i32>)   mapper(@my_mapper) map_clauses(exit_release_or_enter_alloc) capture(ByCopy) bounds(%10) -> !llvm.ptr {name = ""}
 
     // CHECK: omp.target map_entries(%[[MAP0]] -> {{.*}}, %[[MAP1]] -> {{.*}} : !llvm.ptr, !llvm.ptr)
     omp.target map_entries(%mapv1 -> %arg2, %mapv2 -> %arg3 : !llvm.ptr, !llvm.ptr) {

llvmbot · 2024-12-23T19:09:45Z

@llvm/pr-subscribers-mlir

Author: Akash Banerjee (TIFitis)

Changes

This patch adds the mapper field to the omp.map.info op.

Full diff: https://github.com/llvm/llvm-project/pull/120994.diff

3 Files Affected:

(modified) mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td (+2)
(modified) mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp (+1-1)
(modified) mlir/test/Dialect/OpenMP/ops.mlir (+2-2)

diff --git a/mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td b/mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td
index 881f28d42e6312..7cc2c8fa8ce1e1 100644
--- a/mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td
+++ b/mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td
@@ -1000,6 +1000,7 @@ def MapInfoOp : OpenMP_Op<"map.info", [AttrSizedOperandSegments]> {
                        OptionalAttr<IndexListArrayAttr>:$members_index,
                        Variadic<OpenMP_MapBoundsType>:$bounds, /* rank-0 to rank-{n-1} */
                        OptionalAttr<UI64Attr>:$map_type,
+                       OptionalAttr<FlatSymbolRefAttr>:$mapper_id,
                        OptionalAttr<VariableCaptureKindAttr>:$map_capture_type,
                        OptionalAttr<StrAttr>:$name,
                        DefaultValuedAttr<BoolAttr, "false">:$partial_map);
@@ -1064,6 +1065,7 @@ def MapInfoOp : OpenMP_Op<"map.info", [AttrSizedOperandSegments]> {
     `var_ptr` `(` $var_ptr `:` type($var_ptr) `,` $var_type `)`
     oilist(
         `var_ptr_ptr` `(` $var_ptr_ptr `:` type($var_ptr_ptr) `)`
+      | `mapper` `(` $mapper_id `)`
       | `map_clauses` `(` custom<MapClause>($map_type) `)`
       | `capture` `(` custom<CaptureType>($map_capture_type) `)`
       | `members` `(` $members `:` custom<MembersIndex>($members_index) `:` type($members) `)`
diff --git a/mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp b/mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp
index b15d6ed15244ed..92233654ba1ddc 100644
--- a/mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp
+++ b/mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp
@@ -1592,7 +1592,7 @@ static LogicalResult verifyMapClause(Operation *op, OperandRange mapVars) {
 
         to ? updateToVars.insert(updateVar) : updateFromVars.insert(updateVar);
       }
-    } else {
+    } else if (!isa<DeclareMapperInfoOp>(op)) {
       emitError(op->getLoc(), "map argument is not a map entry operation");
     }
   }
diff --git a/mlir/test/Dialect/OpenMP/ops.mlir b/mlir/test/Dialect/OpenMP/ops.mlir
index a167c8bd1abbf9..97ef132f6dfa53 100644
--- a/mlir/test/Dialect/OpenMP/ops.mlir
+++ b/mlir/test/Dialect/OpenMP/ops.mlir
@@ -2523,13 +2523,13 @@ func.func @omp_targets_with_map_bounds(%arg0: !llvm.ptr, %arg1: !llvm.ptr) -> ()
   // CHECK: %[[C_12:.*]] = llvm.mlir.constant(2 : index) : i64
   // CHECK: %[[C_13:.*]] = llvm.mlir.constant(2 : index) : i64
   // CHECK: %[[BOUNDS1:.*]] = omp.map.bounds   lower_bound(%[[C_11]] : i64) upper_bound(%[[C_10]] : i64) stride(%[[C_12]] : i64) start_idx(%[[C_13]] : i64)
-  // CHECK: %[[MAP1:.*]] = omp.map.info var_ptr(%[[ARG1]] : !llvm.ptr, !llvm.array<10 x i32>)   map_clauses(exit_release_or_enter_alloc) capture(ByCopy) bounds(%[[BOUNDS1]]) -> !llvm.ptr {name = ""}
+  // CHECK: %[[MAP1:.*]] = omp.map.info var_ptr(%[[ARG1]] : !llvm.ptr, !llvm.array<10 x i32>)   mapper(@my_mapper) map_clauses(exit_release_or_enter_alloc) capture(ByCopy) bounds(%[[BOUNDS1]]) -> !llvm.ptr {name = ""}
     %6 = llvm.mlir.constant(9 : index) : i64
     %7 = llvm.mlir.constant(1 : index) : i64
     %8 = llvm.mlir.constant(2 : index) : i64
     %9 = llvm.mlir.constant(2 : index) : i64
     %10 = omp.map.bounds   lower_bound(%7 : i64) upper_bound(%6 : i64) stride(%8 : i64) start_idx(%9 : i64)
-    %mapv2 = omp.map.info var_ptr(%arg1 : !llvm.ptr, !llvm.array<10 x i32>)   map_clauses(exit_release_or_enter_alloc) capture(ByCopy) bounds(%10) -> !llvm.ptr {name = ""}
+    %mapv2 = omp.map.info var_ptr(%arg1 : !llvm.ptr, !llvm.array<10 x i32>)   mapper(@my_mapper) map_clauses(exit_release_or_enter_alloc) capture(ByCopy) bounds(%10) -> !llvm.ptr {name = ""}
 
     // CHECK: omp.target map_entries(%[[MAP0]] -> {{.*}}, %[[MAP1]] -> {{.*}} : !llvm.ptr, !llvm.ptr)
     omp.target map_entries(%mapv1 -> %arg2, %mapv2 -> %arg3 : !llvm.ptr, !llvm.ptr) {

llvmbot · 2024-12-23T19:09:45Z

@llvm/pr-subscribers-mlir-openmp

Author: Akash Banerjee (TIFitis)

Changes

This patch adds the mapper field to the omp.map.info op.

Full diff: https://github.com/llvm/llvm-project/pull/120994.diff

3 Files Affected:

(modified) mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td (+2)
(modified) mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp (+1-1)
(modified) mlir/test/Dialect/OpenMP/ops.mlir (+2-2)

diff --git a/mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td b/mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td
index 881f28d42e6312..7cc2c8fa8ce1e1 100644
--- a/mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td
+++ b/mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td
@@ -1000,6 +1000,7 @@ def MapInfoOp : OpenMP_Op<"map.info", [AttrSizedOperandSegments]> {
                        OptionalAttr<IndexListArrayAttr>:$members_index,
                        Variadic<OpenMP_MapBoundsType>:$bounds, /* rank-0 to rank-{n-1} */
                        OptionalAttr<UI64Attr>:$map_type,
+                       OptionalAttr<FlatSymbolRefAttr>:$mapper_id,
                        OptionalAttr<VariableCaptureKindAttr>:$map_capture_type,
                        OptionalAttr<StrAttr>:$name,
                        DefaultValuedAttr<BoolAttr, "false">:$partial_map);
@@ -1064,6 +1065,7 @@ def MapInfoOp : OpenMP_Op<"map.info", [AttrSizedOperandSegments]> {
     `var_ptr` `(` $var_ptr `:` type($var_ptr) `,` $var_type `)`
     oilist(
         `var_ptr_ptr` `(` $var_ptr_ptr `:` type($var_ptr_ptr) `)`
+      | `mapper` `(` $mapper_id `)`
       | `map_clauses` `(` custom<MapClause>($map_type) `)`
       | `capture` `(` custom<CaptureType>($map_capture_type) `)`
       | `members` `(` $members `:` custom<MembersIndex>($members_index) `:` type($members) `)`
diff --git a/mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp b/mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp
index b15d6ed15244ed..92233654ba1ddc 100644
--- a/mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp
+++ b/mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp
@@ -1592,7 +1592,7 @@ static LogicalResult verifyMapClause(Operation *op, OperandRange mapVars) {
 
         to ? updateToVars.insert(updateVar) : updateFromVars.insert(updateVar);
       }
-    } else {
+    } else if (!isa<DeclareMapperInfoOp>(op)) {
       emitError(op->getLoc(), "map argument is not a map entry operation");
     }
   }
diff --git a/mlir/test/Dialect/OpenMP/ops.mlir b/mlir/test/Dialect/OpenMP/ops.mlir
index a167c8bd1abbf9..97ef132f6dfa53 100644
--- a/mlir/test/Dialect/OpenMP/ops.mlir
+++ b/mlir/test/Dialect/OpenMP/ops.mlir
@@ -2523,13 +2523,13 @@ func.func @omp_targets_with_map_bounds(%arg0: !llvm.ptr, %arg1: !llvm.ptr) -> ()
   // CHECK: %[[C_12:.*]] = llvm.mlir.constant(2 : index) : i64
   // CHECK: %[[C_13:.*]] = llvm.mlir.constant(2 : index) : i64
   // CHECK: %[[BOUNDS1:.*]] = omp.map.bounds   lower_bound(%[[C_11]] : i64) upper_bound(%[[C_10]] : i64) stride(%[[C_12]] : i64) start_idx(%[[C_13]] : i64)
-  // CHECK: %[[MAP1:.*]] = omp.map.info var_ptr(%[[ARG1]] : !llvm.ptr, !llvm.array<10 x i32>)   map_clauses(exit_release_or_enter_alloc) capture(ByCopy) bounds(%[[BOUNDS1]]) -> !llvm.ptr {name = ""}
+  // CHECK: %[[MAP1:.*]] = omp.map.info var_ptr(%[[ARG1]] : !llvm.ptr, !llvm.array<10 x i32>)   mapper(@my_mapper) map_clauses(exit_release_or_enter_alloc) capture(ByCopy) bounds(%[[BOUNDS1]]) -> !llvm.ptr {name = ""}
     %6 = llvm.mlir.constant(9 : index) : i64
     %7 = llvm.mlir.constant(1 : index) : i64
     %8 = llvm.mlir.constant(2 : index) : i64
     %9 = llvm.mlir.constant(2 : index) : i64
     %10 = omp.map.bounds   lower_bound(%7 : i64) upper_bound(%6 : i64) stride(%8 : i64) start_idx(%9 : i64)
-    %mapv2 = omp.map.info var_ptr(%arg1 : !llvm.ptr, !llvm.array<10 x i32>)   map_clauses(exit_release_or_enter_alloc) capture(ByCopy) bounds(%10) -> !llvm.ptr {name = ""}
+    %mapv2 = omp.map.info var_ptr(%arg1 : !llvm.ptr, !llvm.array<10 x i32>)   mapper(@my_mapper) map_clauses(exit_release_or_enter_alloc) capture(ByCopy) bounds(%10) -> !llvm.ptr {name = ""}
 
     // CHECK: omp.target map_entries(%[[MAP0]] -> {{.*}}, %[[MAP1]] -> {{.*}} : !llvm.ptr, !llvm.ptr)
     omp.target map_entries(%mapv1 -> %arg2, %mapv2 -> %arg3 : !llvm.ptr, !llvm.ptr) {

ergawy

LGTM

kiranchandramohan · 2025-01-10T16:10:58Z

mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td

@@ -1000,6 +1000,7 @@ def MapInfoOp : OpenMP_Op<"map.info", [AttrSizedOperandSegments]> {
                       OptionalAttr<IndexListArrayAttr>:$members_index,
                       Variadic<OpenMP_MapBoundsType>:$bounds, /* rank-0 to rank-{n-1} */
                       OptionalAttr<UI64Attr>:$map_type,
+                       OptionalAttr<FlatSymbolRefAttr>:$mapper_id,


Please add a description for this argument.

If it can only be the name of a declare mapper then it might be good to add that to the verifier.

Sorry for the delay, I was on vacation.

I've updated the description and also added a verifier check.

skatrak

LGTM, thanks!

skatrak · 2025-02-07T15:42:10Z

One small comment, though. Please trigger a not-yet-implemented error when translating all operations taking map clauses if the new field is set. That would be in checkImplementationStatus, in OpenMPToLLVMIRTranslation.cpp.

TIFitis · 2025-02-07T16:00:41Z

One small comment, though. Please trigger a not-yet-implemented error when translating all operations taking map clauses if the new field is set. That would be in checkImplementationStatus, in OpenMPToLLVMIRTranslation.cpp.

Is that necessary given I have the entire implementation in place? I am planning on merging the entire series in one go.

skatrak · 2025-02-10T11:42:03Z

Is that necessary given I have the entire implementation in place? I am planning on merging the entire series in one go.

If you plan on merging the whole stack at once and if it will add support for declare mappers to all operations that take map clauses, then I agree it would be fine to skip adding any not-yet-implemented errors here.

…clause (#121001) Add Lowering support for OpenMP mapper field in mapInfoOp. NOTE: This patch only supports explicit mapper lowering. I'll add a separate PR soon which handles implicit default mapper recognition. Depends on #120994.

This patch adds the mapper field to the omp.map.info op. Depends on llvm#117046.

…clause (llvm#121001) Add Lowering support for OpenMP mapper field in mapInfoOp. NOTE: This patch only supports explicit mapper lowering. I'll add a separate PR soon which handles implicit default mapper recognition. Depends on llvm#120994.

land and revert: 785a5b4 [MLIR][OpenMP] Add LLVM translation support for OpenMP UserDefinedMappers (llvm#124746) d6ab12c [MLIR][OpenMP] Add conversion support from FIR to LLVM Dialect for OMP DeclareMapper (llvm#121005) 886b2ed [MLIR][OpenMP] Add Lowering support for OpenMP custom mappers in map clause (llvm#121001) ee17955 [MLIR][OpenMP] Add OMP Mapper field to MapInfoOp (llvm#120994)

This patch adds the mapper field to the omp.map.info op. Depends on llvm#117046.

…clause (llvm#121001) Add Lowering support for OpenMP mapper field in mapInfoOp. NOTE: This patch only supports explicit mapper lowering. I'll add a separate PR soon which handles implicit default mapper recognition. Depends on llvm#120994.

This patch adds the mapper field to the omp.map.info op. Depends on llvm#117046.

…clause (llvm#121001) Add Lowering support for OpenMP mapper field in mapInfoOp. NOTE: This patch only supports explicit mapper lowering. I'll add a separate PR soon which handles implicit default mapper recognition. Depends on llvm#120994.

TIFitis requested review from ergawy, skatrak, kiranchandramohan, agozillon and kparzysz December 23, 2024 19:09

llvmbot added mlir mlir:openmp flang:openmp labels Dec 23, 2024

TIFitis force-pushed the users/akash/mapper_clause branch from 21178b0 to 0b54caf Compare December 23, 2024 20:48

llvmbot added flang Flang issues not falling into any other category flang:fir-hlfir labels Dec 23, 2024

TIFitis force-pushed the users/akash/mapper_clause branch from 0b54caf to 002d715 Compare December 23, 2024 20:54

TIFitis mentioned this pull request Dec 23, 2024

[MLIR][OpenMP] Add Lowering support for OpenMP custom mappers in map clause #121001

Merged

ergawy approved these changes Jan 6, 2025

View reviewed changes

kiranchandramohan reviewed Jan 10, 2025

View reviewed changes

skatrak approved these changes Feb 7, 2025

View reviewed changes

TIFitis force-pushed the users/akash/mapper_lowering branch from 49305ab to 7fb1429 Compare February 7, 2025 17:26

TIFitis force-pushed the users/akash/mapper_clause branch from 5ca5a1f to 86513d3 Compare February 7, 2025 17:29

TIFitis force-pushed the users/akash/mapper_lowering branch from 7fb1429 to 3c15b95 Compare February 10, 2025 17:02

TIFitis force-pushed the users/akash/mapper_clause branch from 86513d3 to e93c05d Compare February 10, 2025 17:12

TIFitis force-pushed the users/akash/mapper_lowering branch from 3c15b95 to 5d7a402 Compare February 10, 2025 20:05

TIFitis force-pushed the users/akash/mapper_clause branch from e93c05d to e905951 Compare February 10, 2025 20:06

TIFitis force-pushed the users/akash/mapper_lowering branch from 5d7a402 to aa7f4aa Compare February 11, 2025 16:32

TIFitis force-pushed the users/akash/mapper_clause branch from e905951 to 19e22eb Compare February 11, 2025 16:33

TIFitis force-pushed the users/akash/mapper_lowering branch from aa7f4aa to afb17c9 Compare February 18, 2025 16:22

TIFitis force-pushed the users/akash/mapper_clause branch from 19e22eb to 04831ef Compare February 18, 2025 16:28

Base automatically changed from users/akash/mapper_lowering to main February 18, 2025 16:36

TIFitis added 2 commits February 18, 2025 17:26

Add mapper field to mapInfoOp.

8f3cad9

Add description for mapper_id. Add verifier check for valid mapper_id.

03838f7

TIFitis force-pushed the users/akash/mapper_clause branch from 04831ef to 03838f7 Compare February 18, 2025 17:26

TIFitis merged commit ee17955 into main Feb 18, 2025
4 of 6 checks passed

TIFitis deleted the users/akash/mapper_clause branch February 18, 2025 17:27

wldfngrs pushed a commit to wldfngrs/llvm-project that referenced this pull request Feb 19, 2025

[MLIR][OpenMP] Add OMP Mapper field to MapInfoOp (llvm#120994)

86c069f

This patch adds the mapper field to the omp.map.info op. Depends on llvm#117046.

TIFitis added a commit to TIFitis/llvm-project that referenced this pull request Feb 20, 2025

[MLIR][OpenMP] Add OMP Mapper field to MapInfoOp (llvm#120994)

8d8470f

This patch adds the mapper field to the omp.map.info op. Depends on llvm#117046.

TIFitis mentioned this pull request Feb 20, 2025

Merge Declare Mapper patches. ROCm/llvm-project#250

Closed

searlmc1 pushed a commit to ROCm/llvm-project that referenced this pull request Feb 22, 2025

[MLIR][OpenMP] Add OMP Mapper field to MapInfoOp (llvm#120994)

d607ed7

This patch adds the mapper field to the omp.map.info op. Depends on llvm#117046.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[MLIR][OpenMP] Add OMP Mapper field to MapInfoOp #120994

[MLIR][OpenMP] Add OMP Mapper field to MapInfoOp #120994

Uh oh!

TIFitis commented Dec 23, 2024 •

edited

Loading

Uh oh!

llvmbot commented Dec 23, 2024 •

edited

Loading

Uh oh!

llvmbot commented Dec 23, 2024

Uh oh!

llvmbot commented Dec 23, 2024

Uh oh!

ergawy left a comment

Uh oh!

kiranchandramohan Jan 10, 2025

Uh oh!

kiranchandramohan Jan 10, 2025

Uh oh!

TIFitis Jan 28, 2025

Uh oh!

skatrak left a comment

Uh oh!

skatrak commented Feb 7, 2025

Uh oh!

TIFitis commented Feb 7, 2025

Uh oh!

skatrak commented Feb 10, 2025

Uh oh!

Uh oh!

Uh oh!

[MLIR][OpenMP] Add OMP Mapper field to MapInfoOp #120994

[MLIR][OpenMP] Add OMP Mapper field to MapInfoOp #120994

Uh oh!

Conversation

TIFitis commented Dec 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

llvmbot commented Dec 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

llvmbot commented Dec 23, 2024

Uh oh!

llvmbot commented Dec 23, 2024

Uh oh!

ergawy left a comment

Choose a reason for hiding this comment

Uh oh!

kiranchandramohan Jan 10, 2025

Choose a reason for hiding this comment

Uh oh!

kiranchandramohan Jan 10, 2025

Choose a reason for hiding this comment

Uh oh!

TIFitis Jan 28, 2025

Choose a reason for hiding this comment

Uh oh!

skatrak left a comment

Choose a reason for hiding this comment

Uh oh!

skatrak commented Feb 7, 2025

Uh oh!

TIFitis commented Feb 7, 2025

Uh oh!

skatrak commented Feb 10, 2025

Uh oh!

Uh oh!

Uh oh!

TIFitis commented Dec 23, 2024 •

edited

Loading

llvmbot commented Dec 23, 2024 •

edited

Loading