[MLIR][OpenMP] Add Lowering support for OpenMP custom mappers in map clause #121001

TIFitis · 2024-12-23T21:18:01Z

Add Lowering support for OpenMP mapper field in mapInfoOp.

NOTE: This patch only supports explicit mapper lowering. I'll add a separate PR soon which handles implicit default mapper recognition.

Depends on #120994.

llvmbot · 2024-12-23T21:18:34Z

@llvm/pr-subscribers-flang-openmp

Author: Akash Banerjee (TIFitis)

Changes

Add Lowering support for OpenMP mapper field in mapInfoOp.

Depends on #120994.

Full diff: https://github.com/llvm/llvm-project/pull/121001.diff

4 Files Affected:

(modified) flang/lib/Lower/OpenMP/ClauseProcessor.cpp (+27-5)
(modified) flang/lib/Lower/OpenMP/ClauseProcessor.h (+2-1)
(removed) flang/test/Lower/OpenMP/Todo/map-mapper.f90 (-16)
(added) flang/test/Lower/OpenMP/map-mapper.f90 (+23)

diff --git a/flang/lib/Lower/OpenMP/ClauseProcessor.cpp b/flang/lib/Lower/OpenMP/ClauseProcessor.cpp
index 3c9831120351ee..0bc9f4919330e4 100644
--- a/flang/lib/Lower/OpenMP/ClauseProcessor.cpp
+++ b/flang/lib/Lower/OpenMP/ClauseProcessor.cpp
@@ -936,8 +936,10 @@ void ClauseProcessor::processMapObjects(
     llvm::omp::OpenMPOffloadMappingFlags mapTypeBits,
     std::map<Object, OmpMapParentAndMemberData> &parentMemberIndices,
     llvm::SmallVectorImpl<mlir::Value> &mapVars,
-    llvm::SmallVectorImpl<const semantics::Symbol *> &mapSyms) const {
+    llvm::SmallVectorImpl<const semantics::Symbol *> &mapSyms,
+    std::string mapperIdName) const {
   fir::FirOpBuilder &firOpBuilder = converter.getFirOpBuilder();
+  mlir::FlatSymbolRefAttr mapperId;
 
   for (const omp::Object &object : objects) {
     llvm::SmallVector<mlir::Value> bounds;
@@ -970,6 +972,20 @@ void ClauseProcessor::processMapObjects(
       }
     }
 
+    if (!mapperIdName.empty()) {
+      if (mapperIdName == "default") {
+        auto &typeSpec = object.sym()->owner().IsDerivedType()
+                             ? *object.sym()->owner().derivedTypeSpec()
+                             : object.sym()->GetType()->derivedTypeSpec();
+        mapperIdName = typeSpec.name().ToString() + ".default";
+        mapperIdName = converter.mangleName(mapperIdName, *typeSpec.GetScope());
+      }
+      assert(converter.getMLIRSymbolTable()->lookup(mapperIdName) &&
+             "mapper not found");
+      mapperId = mlir::FlatSymbolRefAttr::get(&converter.getMLIRContext(),
+                                              mapperIdName);
+      mapperIdName.clear();
+    }
     // Explicit map captures are captured ByRef by default,
     // optimisation passes may alter this to ByCopy or other capture
     // types to optimise
@@ -983,7 +999,8 @@ void ClauseProcessor::processMapObjects(
         static_cast<
             std::underlying_type_t<llvm::omp::OpenMPOffloadMappingFlags>>(
             mapTypeBits),
-        mlir::omp::VariableCaptureKind::ByRef, baseOp.getType());
+        mlir::omp::VariableCaptureKind::ByRef, baseOp.getType(), false,
+        mapperId);
 
     if (parentObj.has_value()) {
       parentMemberIndices[parentObj.value()].addChildIndexAndMapToParent(
@@ -1014,6 +1031,7 @@ bool ClauseProcessor::processMap(
     const auto &[mapType, typeMods, mappers, iterator, objects] = clause.t;
     llvm::omp::OpenMPOffloadMappingFlags mapTypeBits =
         llvm::omp::OpenMPOffloadMappingFlags::OMP_MAP_NONE;
+    std::string mapperIdName;
     // If the map type is specified, then process it else Tofrom is the
     // default.
     Map::MapType type = mapType.value_or(Map::MapType::Tofrom);
@@ -1057,13 +1075,17 @@ bool ClauseProcessor::processMap(
            "Support for iterator modifiers is not implemented yet");
     }
     if (mappers) {
-      TODO(currentLocation,
-           "Support for mapper modifiers is not implemented yet");
+      assert(mappers->size() == 1 && "more than one mapper");
+      mapperIdName = mappers->front().v.id().symbol->name().ToString();
+      if (mapperIdName != "default")
+        mapperIdName = converter.mangleName(
+            mapperIdName, mappers->front().v.id().symbol->owner());
     }
 
     processMapObjects(stmtCtx, clauseLocation,
                       std::get<omp::ObjectList>(clause.t), mapTypeBits,
-                      parentMemberIndices, result.mapVars, *ptrMapSyms);
+                      parentMemberIndices, result.mapVars, *ptrMapSyms,
+                      mapperIdName);
   };
 
   bool clauseFound = findRepeatableClause<omp::clause::Map>(process);
diff --git a/flang/lib/Lower/OpenMP/ClauseProcessor.h b/flang/lib/Lower/OpenMP/ClauseProcessor.h
index 7b047d4a7567ad..34eebf16ca17b0 100644
--- a/flang/lib/Lower/OpenMP/ClauseProcessor.h
+++ b/flang/lib/Lower/OpenMP/ClauseProcessor.h
@@ -171,7 +171,8 @@ class ClauseProcessor {
       llvm::omp::OpenMPOffloadMappingFlags mapTypeBits,
       std::map<Object, OmpMapParentAndMemberData> &parentMemberIndices,
       llvm::SmallVectorImpl<mlir::Value> &mapVars,
-      llvm::SmallVectorImpl<const semantics::Symbol *> &mapSyms) const;
+      llvm::SmallVectorImpl<const semantics::Symbol *> &mapSyms,
+      std::string mapperIdName = "") const;
 
   lower::AbstractConverter &converter;
   semantics::SemanticsContext &semaCtx;
diff --git a/flang/test/Lower/OpenMP/Todo/map-mapper.f90 b/flang/test/Lower/OpenMP/Todo/map-mapper.f90
deleted file mode 100644
index 9554ffd5fda7bd..00000000000000
--- a/flang/test/Lower/OpenMP/Todo/map-mapper.f90
+++ /dev/null
@@ -1,16 +0,0 @@
-! RUN: not %flang_fc1 -emit-fir -fopenmp -fopenmp-version=50 %s 2>&1 | FileCheck %s
-program p
-  integer, parameter :: n = 256
-  real(8) :: a(256)
-  !! TODO: Add declare mapper, when it works to lower this construct 
-  !!type t1
-  !!   integer :: x
-  !!end type t1
-  !!!$omp declare mapper(xx : t1 :: nn) map(nn, nn%x)
-  !$omp target map(mapper(xx), from:a)
-!CHECK: not yet implemented: Support for mapper modifiers is not implemented yet
-  do i=1,n
-     a(i) = 4.2
-  end do
-  !$omp end target
-end program p
diff --git a/flang/test/Lower/OpenMP/map-mapper.f90 b/flang/test/Lower/OpenMP/map-mapper.f90
new file mode 100644
index 00000000000000..856fff834643e4
--- /dev/null
+++ b/flang/test/Lower/OpenMP/map-mapper.f90
@@ -0,0 +1,23 @@
+! RUN: %flang_fc1 -emit-hlfir -fopenmp -fopenmp-version=50 %s -o - | FileCheck %s
+program p
+   integer, parameter :: n = 256
+   type t1
+      integer :: x(256)
+   end type t1
+
+   !$omp declare mapper(xx : t1 :: nn) map(to: nn, nn%x)
+   !$omp declare mapper(t1 :: nn) map(from: nn)
+
+   !CHECK-LABEL: omp.declare_mapper @_QQFt1.default : !fir.type<_QFTt1{x:!fir.array<256xi32>}>
+   !CHECK-LABEL: omp.declare_mapper @_QQFxx : !fir.type<_QFTt1{x:!fir.array<256xi32>}>
+
+   type(t1) :: a, b
+   !CHECK: %[[MAP_A:.*]] = omp.map.info var_ptr(%{{.*}} : {{.*}}, {{.*}}) mapper(@_QQFxx) map_clauses(tofrom) capture(ByRef) -> {{.*}} {name = "a"}
+   !CHECK: %[[MAP_B:.*]] = omp.map.info var_ptr(%{{.*}} : {{.*}}, {{.*}}) mapper(@_QQFt1.default) map_clauses(tofrom) capture(ByRef) -> {{.*}} {name = "b"}
+   !CHECK: omp.target map_entries(%[[MAP_A]] -> %{{.*}}, %[[MAP_B]] -> %{{.*}}, %{{.*}} -> %{{.*}}, %{{.*}} -> %{{.*}} : {{.*}}, {{.*}}, {{.*}}, {{.*}}) {
+   !$omp target map(mapper(xx) : a) map(mapper(default) : b)
+   do i = 1, n
+      b%x(i) = a%x(i)
+   end do
+   !$omp end target
+end program p

llvmbot · 2024-12-23T21:18:35Z

@llvm/pr-subscribers-flang-fir-hlfir

Author: Akash Banerjee (TIFitis)

Changes

Add Lowering support for OpenMP mapper field in mapInfoOp.

Depends on #120994.

Full diff: https://github.com/llvm/llvm-project/pull/121001.diff

4 Files Affected:

(modified) flang/lib/Lower/OpenMP/ClauseProcessor.cpp (+27-5)
(modified) flang/lib/Lower/OpenMP/ClauseProcessor.h (+2-1)
(removed) flang/test/Lower/OpenMP/Todo/map-mapper.f90 (-16)
(added) flang/test/Lower/OpenMP/map-mapper.f90 (+23)

diff --git a/flang/lib/Lower/OpenMP/ClauseProcessor.cpp b/flang/lib/Lower/OpenMP/ClauseProcessor.cpp
index 3c9831120351ee..0bc9f4919330e4 100644
--- a/flang/lib/Lower/OpenMP/ClauseProcessor.cpp
+++ b/flang/lib/Lower/OpenMP/ClauseProcessor.cpp
@@ -936,8 +936,10 @@ void ClauseProcessor::processMapObjects(
     llvm::omp::OpenMPOffloadMappingFlags mapTypeBits,
     std::map<Object, OmpMapParentAndMemberData> &parentMemberIndices,
     llvm::SmallVectorImpl<mlir::Value> &mapVars,
-    llvm::SmallVectorImpl<const semantics::Symbol *> &mapSyms) const {
+    llvm::SmallVectorImpl<const semantics::Symbol *> &mapSyms,
+    std::string mapperIdName) const {
   fir::FirOpBuilder &firOpBuilder = converter.getFirOpBuilder();
+  mlir::FlatSymbolRefAttr mapperId;
 
   for (const omp::Object &object : objects) {
     llvm::SmallVector<mlir::Value> bounds;
@@ -970,6 +972,20 @@ void ClauseProcessor::processMapObjects(
       }
     }
 
+    if (!mapperIdName.empty()) {
+      if (mapperIdName == "default") {
+        auto &typeSpec = object.sym()->owner().IsDerivedType()
+                             ? *object.sym()->owner().derivedTypeSpec()
+                             : object.sym()->GetType()->derivedTypeSpec();
+        mapperIdName = typeSpec.name().ToString() + ".default";
+        mapperIdName = converter.mangleName(mapperIdName, *typeSpec.GetScope());
+      }
+      assert(converter.getMLIRSymbolTable()->lookup(mapperIdName) &&
+             "mapper not found");
+      mapperId = mlir::FlatSymbolRefAttr::get(&converter.getMLIRContext(),
+                                              mapperIdName);
+      mapperIdName.clear();
+    }
     // Explicit map captures are captured ByRef by default,
     // optimisation passes may alter this to ByCopy or other capture
     // types to optimise
@@ -983,7 +999,8 @@ void ClauseProcessor::processMapObjects(
         static_cast<
             std::underlying_type_t<llvm::omp::OpenMPOffloadMappingFlags>>(
             mapTypeBits),
-        mlir::omp::VariableCaptureKind::ByRef, baseOp.getType());
+        mlir::omp::VariableCaptureKind::ByRef, baseOp.getType(), false,
+        mapperId);
 
     if (parentObj.has_value()) {
       parentMemberIndices[parentObj.value()].addChildIndexAndMapToParent(
@@ -1014,6 +1031,7 @@ bool ClauseProcessor::processMap(
     const auto &[mapType, typeMods, mappers, iterator, objects] = clause.t;
     llvm::omp::OpenMPOffloadMappingFlags mapTypeBits =
         llvm::omp::OpenMPOffloadMappingFlags::OMP_MAP_NONE;
+    std::string mapperIdName;
     // If the map type is specified, then process it else Tofrom is the
     // default.
     Map::MapType type = mapType.value_or(Map::MapType::Tofrom);
@@ -1057,13 +1075,17 @@ bool ClauseProcessor::processMap(
            "Support for iterator modifiers is not implemented yet");
     }
     if (mappers) {
-      TODO(currentLocation,
-           "Support for mapper modifiers is not implemented yet");
+      assert(mappers->size() == 1 && "more than one mapper");
+      mapperIdName = mappers->front().v.id().symbol->name().ToString();
+      if (mapperIdName != "default")
+        mapperIdName = converter.mangleName(
+            mapperIdName, mappers->front().v.id().symbol->owner());
     }
 
     processMapObjects(stmtCtx, clauseLocation,
                       std::get<omp::ObjectList>(clause.t), mapTypeBits,
-                      parentMemberIndices, result.mapVars, *ptrMapSyms);
+                      parentMemberIndices, result.mapVars, *ptrMapSyms,
+                      mapperIdName);
   };
 
   bool clauseFound = findRepeatableClause<omp::clause::Map>(process);
diff --git a/flang/lib/Lower/OpenMP/ClauseProcessor.h b/flang/lib/Lower/OpenMP/ClauseProcessor.h
index 7b047d4a7567ad..34eebf16ca17b0 100644
--- a/flang/lib/Lower/OpenMP/ClauseProcessor.h
+++ b/flang/lib/Lower/OpenMP/ClauseProcessor.h
@@ -171,7 +171,8 @@ class ClauseProcessor {
       llvm::omp::OpenMPOffloadMappingFlags mapTypeBits,
       std::map<Object, OmpMapParentAndMemberData> &parentMemberIndices,
       llvm::SmallVectorImpl<mlir::Value> &mapVars,
-      llvm::SmallVectorImpl<const semantics::Symbol *> &mapSyms) const;
+      llvm::SmallVectorImpl<const semantics::Symbol *> &mapSyms,
+      std::string mapperIdName = "") const;
 
   lower::AbstractConverter &converter;
   semantics::SemanticsContext &semaCtx;
diff --git a/flang/test/Lower/OpenMP/Todo/map-mapper.f90 b/flang/test/Lower/OpenMP/Todo/map-mapper.f90
deleted file mode 100644
index 9554ffd5fda7bd..00000000000000
--- a/flang/test/Lower/OpenMP/Todo/map-mapper.f90
+++ /dev/null
@@ -1,16 +0,0 @@
-! RUN: not %flang_fc1 -emit-fir -fopenmp -fopenmp-version=50 %s 2>&1 | FileCheck %s
-program p
-  integer, parameter :: n = 256
-  real(8) :: a(256)
-  !! TODO: Add declare mapper, when it works to lower this construct 
-  !!type t1
-  !!   integer :: x
-  !!end type t1
-  !!!$omp declare mapper(xx : t1 :: nn) map(nn, nn%x)
-  !$omp target map(mapper(xx), from:a)
-!CHECK: not yet implemented: Support for mapper modifiers is not implemented yet
-  do i=1,n
-     a(i) = 4.2
-  end do
-  !$omp end target
-end program p
diff --git a/flang/test/Lower/OpenMP/map-mapper.f90 b/flang/test/Lower/OpenMP/map-mapper.f90
new file mode 100644
index 00000000000000..856fff834643e4
--- /dev/null
+++ b/flang/test/Lower/OpenMP/map-mapper.f90
@@ -0,0 +1,23 @@
+! RUN: %flang_fc1 -emit-hlfir -fopenmp -fopenmp-version=50 %s -o - | FileCheck %s
+program p
+   integer, parameter :: n = 256
+   type t1
+      integer :: x(256)
+   end type t1
+
+   !$omp declare mapper(xx : t1 :: nn) map(to: nn, nn%x)
+   !$omp declare mapper(t1 :: nn) map(from: nn)
+
+   !CHECK-LABEL: omp.declare_mapper @_QQFt1.default : !fir.type<_QFTt1{x:!fir.array<256xi32>}>
+   !CHECK-LABEL: omp.declare_mapper @_QQFxx : !fir.type<_QFTt1{x:!fir.array<256xi32>}>
+
+   type(t1) :: a, b
+   !CHECK: %[[MAP_A:.*]] = omp.map.info var_ptr(%{{.*}} : {{.*}}, {{.*}}) mapper(@_QQFxx) map_clauses(tofrom) capture(ByRef) -> {{.*}} {name = "a"}
+   !CHECK: %[[MAP_B:.*]] = omp.map.info var_ptr(%{{.*}} : {{.*}}, {{.*}}) mapper(@_QQFt1.default) map_clauses(tofrom) capture(ByRef) -> {{.*}} {name = "b"}
+   !CHECK: omp.target map_entries(%[[MAP_A]] -> %{{.*}}, %[[MAP_B]] -> %{{.*}}, %{{.*}} -> %{{.*}}, %{{.*}} -> %{{.*}} : {{.*}}, {{.*}}, {{.*}}, {{.*}}) {
+   !$omp target map(mapper(xx) : a) map(mapper(default) : b)
+   do i = 1, n
+      b%x(i) = a%x(i)
+   end do
+   !$omp end target
+end program p

flang/lib/Lower/OpenMP/ClauseProcessor.cpp

flang/test/Lower/OpenMP/map-mapper.f90

ergawy

LGTM!

skatrak

Thank you, LGTM. Just some minor nits, no need to wait for another review by me.

skatrak · 2025-02-07T15:26:02Z

flang/lib/Lower/OpenMP/ClauseProcessor.cpp

@@ -936,8 +936,10 @@ void ClauseProcessor::processMapObjects(
    llvm::omp::OpenMPOffloadMappingFlags mapTypeBits,
    std::map<Object, OmpMapParentAndMemberData> &parentMemberIndices,
    llvm::SmallVectorImpl<mlir::Value> &mapVars,
-    llvm::SmallVectorImpl<const semantics::Symbol *> &mapSyms) const {
+    llvm::SmallVectorImpl<const semantics::Symbol *> &mapSyms,
+    std::string mapperIdName) const {


Nit: Use llvm::StringRef.

In this case, even we accept a StringRef, we would have to immediately copy it to a std:string as we need to pass an lvalue to converter.mangleName. As such, wouldn't it be better to accept it as a string.

Accepting a StringRef gives us more flexibility while passing arguments (plus, it gives us the option to rework the implementation to avoid copies later on), it follows LLVM recommendations and I don't see any drawbacks from using it here. In my opinion, I still think it's a better option. If you feel strongly about it, this is not a blocking issue for me.

flang/lib/Lower/OpenMP/ClauseProcessor.cpp

…P DeclareMapper (#121005) Add conversion support from FIR to LLVM Dialect for OMP DeclareMapper. Depends on #121001

…clause (llvm#121001) Add Lowering support for OpenMP mapper field in mapInfoOp. NOTE: This patch only supports explicit mapper lowering. I'll add a separate PR soon which handles implicit default mapper recognition. Depends on llvm#120994.

…P DeclareMapper (llvm#121005) Add conversion support from FIR to LLVM Dialect for OMP DeclareMapper. Depends on llvm#121001

land and revert: 785a5b4 [MLIR][OpenMP] Add LLVM translation support for OpenMP UserDefinedMappers (llvm#124746) d6ab12c [MLIR][OpenMP] Add conversion support from FIR to LLVM Dialect for OMP DeclareMapper (llvm#121005) 886b2ed [MLIR][OpenMP] Add Lowering support for OpenMP custom mappers in map clause (llvm#121001) ee17955 [MLIR][OpenMP] Add OMP Mapper field to MapInfoOp (llvm#120994)

…clause (llvm#121001) Add Lowering support for OpenMP mapper field in mapInfoOp. NOTE: This patch only supports explicit mapper lowering. I'll add a separate PR soon which handles implicit default mapper recognition. Depends on llvm#120994.

…P DeclareMapper (llvm#121005) Add conversion support from FIR to LLVM Dialect for OMP DeclareMapper. Depends on llvm#121001

…clause (llvm#121001) Add Lowering support for OpenMP mapper field in mapInfoOp. NOTE: This patch only supports explicit mapper lowering. I'll add a separate PR soon which handles implicit default mapper recognition. Depends on llvm#120994.

…P DeclareMapper (llvm#121005) Add conversion support from FIR to LLVM Dialect for OMP DeclareMapper. Depends on llvm#121001

TIFitis requested review from ergawy, skatrak, kiranchandramohan, agozillon and kparzysz December 23, 2024 21:18

llvmbot added flang Flang issues not falling into any other category flang:fir-hlfir flang:openmp labels Dec 23, 2024

ergawy reviewed Jan 7, 2025

View reviewed changes

flang/lib/Lower/OpenMP/ClauseProcessor.cpp Show resolved Hide resolved

flang/lib/Lower/OpenMP/ClauseProcessor.cpp Show resolved Hide resolved

flang/test/Lower/OpenMP/map-mapper.f90 Outdated Show resolved Hide resolved

TIFitis mentioned this pull request Jan 28, 2025

[MLIR][OpenMP] Add conversion support from FIR to LLVM Dialect for OMP DeclareMapper #121005

Merged

ergawy approved these changes Jan 30, 2025

View reviewed changes

TIFitis force-pushed the users/akash/mapper_clause_lowering branch from ed3cb3d to 5f892bb Compare January 31, 2025 11:20

skatrak approved these changes Feb 7, 2025

View reviewed changes

TIFitis force-pushed the users/akash/mapper_clause branch from 5ca5a1f to 86513d3 Compare February 7, 2025 17:29

TIFitis force-pushed the users/akash/mapper_clause_lowering branch from 5f892bb to 802c3df Compare February 7, 2025 17:36

TIFitis force-pushed the users/akash/mapper_clause branch from 86513d3 to e93c05d Compare February 10, 2025 17:12

TIFitis force-pushed the users/akash/mapper_clause_lowering branch from 802c3df to 1b3e235 Compare February 10, 2025 17:46

TIFitis force-pushed the users/akash/mapper_clause branch from e93c05d to e905951 Compare February 10, 2025 20:06

TIFitis force-pushed the users/akash/mapper_clause_lowering branch from 1b3e235 to c5b4f50 Compare February 10, 2025 20:06

skatrak reviewed Feb 11, 2025

View reviewed changes

flang/lib/Lower/OpenMP/ClauseProcessor.cpp Show resolved Hide resolved

TIFitis force-pushed the users/akash/mapper_clause branch from e905951 to 19e22eb Compare February 11, 2025 16:33

TIFitis force-pushed the users/akash/mapper_clause_lowering branch from c5b4f50 to e5d0cd9 Compare February 11, 2025 16:50

TIFitis mentioned this pull request Feb 11, 2025

[MLIR][OpenMP] Add Lowering support for OpenMP Declare Mapper directive #117046

Merged

TIFitis force-pushed the users/akash/mapper_clause branch from 19e22eb to 04831ef Compare February 18, 2025 16:28

TIFitis force-pushed the users/akash/mapper_clause_lowering branch from e5d0cd9 to 20a5496 Compare February 18, 2025 16:30

TIFitis force-pushed the users/akash/mapper_clause branch from 04831ef to 03838f7 Compare February 18, 2025 17:26

Base automatically changed from users/akash/mapper_clause to main February 18, 2025 17:27

Add flang lowering changes for mapper field in map clause.

1332013

TIFitis added 4 commits February 18, 2025 17:38

Split test into two separate directives.

e92b4c8

Address reviewer comments.

e3c1388

Replace std:string with llvm::StringRef

b999d72

Add new test.

862fda5

TIFitis force-pushed the users/akash/mapper_clause_lowering branch from 20a5496 to 862fda5 Compare February 18, 2025 17:39

TIFitis merged commit 886b2ed into main Feb 18, 2025
5 of 7 checks passed

TIFitis deleted the users/akash/mapper_clause_lowering branch February 18, 2025 17:40

TIFitis added a commit that referenced this pull request Feb 18, 2025

[MLIR][OpenMP] Add conversion support from FIR to LLVM Dialect for OM…

d6ab12c

…P DeclareMapper (#121005) Add conversion support from FIR to LLVM Dialect for OMP DeclareMapper. Depends on #121001

TIFitis mentioned this pull request Feb 20, 2025

Merge Declare Mapper patches. ROCm/llvm-project#250

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[MLIR][OpenMP] Add Lowering support for OpenMP custom mappers in map clause #121001

[MLIR][OpenMP] Add Lowering support for OpenMP custom mappers in map clause #121001

Uh oh!

TIFitis commented Dec 23, 2024 •

edited

Loading

Uh oh!

llvmbot commented Dec 23, 2024

Uh oh!

llvmbot commented Dec 23, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ergawy left a comment

Uh oh!

skatrak left a comment

Uh oh!

skatrak Feb 7, 2025

Uh oh!

TIFitis Feb 7, 2025

Uh oh!

skatrak Feb 10, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

[MLIR][OpenMP] Add Lowering support for OpenMP custom mappers in map clause #121001

[MLIR][OpenMP] Add Lowering support for OpenMP custom mappers in map clause #121001

Uh oh!

Conversation

TIFitis commented Dec 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

llvmbot commented Dec 23, 2024

Uh oh!

llvmbot commented Dec 23, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ergawy left a comment

Choose a reason for hiding this comment

Uh oh!

skatrak left a comment

Choose a reason for hiding this comment

Uh oh!

skatrak Feb 7, 2025

Choose a reason for hiding this comment

Uh oh!

TIFitis Feb 7, 2025

Choose a reason for hiding this comment

Uh oh!

skatrak Feb 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TIFitis commented Dec 23, 2024 •

edited

Loading