-
Notifications
You must be signed in to change notification settings - Fork 13.6k
[OpenMP][Flang] Workaround omp_lib error #123666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It appears that omp_lib is not correctly (or maybe not at all?) found from the build directory. This made a few buildbots break after PR#121356 landed. This is a workaround to unblock the buildbots.
@llvm/pr-subscribers-flang-openmp @llvm/pr-subscribers-flang-fir-hlfir Author: Jan Patrick Lehr (jplehr) ChangesIt appears that omp_lib is not correctly (or maybe not at all?) found from the build directory. This made a few buildbots break after PR#121356 landed. https://lab.llvm.org/staging/#/builders/130/builds/12654 Full diff: https://github.com/llvm/llvm-project/pull/123666.diff 1 Files Affected:
diff --git a/flang/test/Lower/OpenMP/Todo/allocate-clause-allocator.f90 b/flang/test/Lower/OpenMP/Todo/allocate-clause-allocator.f90
index d33bdf9f9a8db2..90158a61f75039 100644
--- a/flang/test/Lower/OpenMP/Todo/allocate-clause-allocator.f90
+++ b/flang/test/Lower/OpenMP/Todo/allocate-clause-allocator.f90
@@ -4,7 +4,8 @@
! CHECK: not yet implemented: Unhandled clause allocate in omp.parallel
! CHECK: LLVM Translation failed for operation: omp.parallel
program p
- use omp_lib
+ !use omp_lib
+ integer(8),parameter::omp_default_mem_alloc=1_8
integer :: x
integer :: a
integer :: i
|
This is a problem that comes back over and over again. The module files are not updated correctly when they need to be, but the need for update may be hard for cmake to figure out automatically. Maybe they should be regenerated from scratch every time in target |
Hmm... I looked around and it appears that the |
Scratch that. I just checked again and the |
Thanks for fixing this |
After the crude workaround in llvm/llvm-project#123666, @mjklemm suggested this change instead to address the issue. Local testing did not show errors, so I'm inclined to land it and see what the buildbots think.
It appears that omp_lib is not correctly (or maybe not at all?) found from the build directory. This made a few buildbots break after PR#121356 landed.
This is a workaround to unblock the buildbots.
https://lab.llvm.org/staging/#/builders/130/builds/12654
https://lab.llvm.org/buildbot/#/builders/140/builds/15102
https://lab.llvm.org/staging/#/builders/105/builds/13855