Skip to content

[Flang][OpenMP] Fix run line w/ use mod_lib #123762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Conversation

jplehr
Copy link
Contributor

@jplehr jplehr commented Jan 21, 2025

After the crude workaround in #123666, @mjklemm suggested this change instead to address the issue.
Local testing did not show errors, so I'm inclined to land it and see what the buildbots think.

@llvmbot llvmbot added flang Flang issues not falling into any other category flang:fir-hlfir flang:openmp labels Jan 21, 2025
@llvmbot
Copy link
Member

llvmbot commented Jan 21, 2025

@llvm/pr-subscribers-flang-fir-hlfir

@llvm/pr-subscribers-flang-openmp

Author: Jan Patrick Lehr (jplehr)

Changes

After the crude workaround in #123666, @mjklemm suggested this change instead to address the issue.
Local testing did not show errors, so I'm inclined to land it and see what the buildbots think.


Full diff: https://github.com/llvm/llvm-project/pull/123762.diff

1 Files Affected:

  • (modified) flang/test/Lower/OpenMP/Todo/allocate-clause-allocator.f90 (+2-3)
diff --git a/flang/test/Lower/OpenMP/Todo/allocate-clause-allocator.f90 b/flang/test/Lower/OpenMP/Todo/allocate-clause-allocator.f90
index 90158a61f75039..45b3aa8ee77f91 100644
--- a/flang/test/Lower/OpenMP/Todo/allocate-clause-allocator.f90
+++ b/flang/test/Lower/OpenMP/Todo/allocate-clause-allocator.f90
@@ -1,11 +1,10 @@
 ! REQUIRES: openmp_runtime
-! RUN: %not_todo_cmd %flang_fc1 -emit-llvm -fopenmp -fopenmp-version=51 -o - %s 2>&1 | FileCheck %s
+! RUN: %not_todo_cmd %flang_fc1 -emit-llvm %openmp_flags -fopenmp-version=51 -o - %s 2>&1 | FileCheck %s
 
 ! CHECK: not yet implemented: Unhandled clause allocate in omp.parallel
 ! CHECK: LLVM Translation failed for operation: omp.parallel
 program p
-  !use omp_lib
-  integer(8),parameter::omp_default_mem_alloc=1_8
+  use omp_lib
   integer :: x
   integer :: a
   integer :: i

@jplehr jplehr merged commit baeedd7 into llvm:main Jan 21, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flang:fir-hlfir flang:openmp flang Flang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants