[NFC][Cloning] Add a helper to collect debug info from instructions

[artempyanykh]

Stacked PRs:

• [NFC][Cloning] Move DebugInfoFinder decl closer to its place of usage #129154
• [NFC][Cloning] Clean up comments in CloneFunctionInto #129153
• [NFC][Cloning] Remove now unused CollectDebugInfoForCloning #129152
• [NFC][Cloning] Remove now unused FindDebugInfoToIdentityMap #129151
• [NFC][Coro] Remove now unused CommonDebugInfo in CoroSplit #129150
• [NFC][Coro] Use CloneFunctionInto for coroutine cloning instead of CloneFunction<Part> #129149
• [NFC][Cloning] Replace DIFinder usage in CloneFunctionInto with a MetadataPredicate #129148
• [NFC][Cloning] Replace IdentityMD set with a predicate in ValueMapper #129147
• [NFC][Cloning] Make DifferentModule case more obvious in CollectDebugInfoForCloning #129146
• ->[NFC][Cloning] Add a helper to collect debug info from instructions #129145
• [NFC][Cloning] Simplify the flow in FindDebugInfoToIdentityMap #129144
• [NFC][Cloning] Make ClonedModule case more obvious in CollectDebugInfoForCloning #129143

---

[NFC][Cloning] Add a helper to collect debug info from instructions

Summary:
Just moving around. This helper will be used for further refactoring.

Test Plan:
ninja check-llvm-unit check-llvm

[llvmbot]

@llvm/pr-subscribers-llvm-transforms

Author: Artem Pianykh (artempyanykh)

Changes

[NFC][Cloning] Add a helper to collect debug info from instructions

Summary:
Just moving around. This helper will be used for further refactoring.

Test Plan:
ninja check-llvm-unit check-llvm

---

Full diff: https://github.com/llvm/llvm-project/pull/129145.diff

1 Files Affected:

• (modified) llvm/lib/Transforms/Utils/CloneFunction.cpp (+13-6)

diff --git a/llvm/lib/Transforms/Utils/CloneFunction.cpp b/llvm/lib/Transforms/Utils/CloneFunction.cpp
index 5a5b84c8e0a3c..9ea4e64671c7e 100644
--- a/llvm/lib/Transforms/Utils/CloneFunction.cpp
+++ b/llvm/lib/Transforms/Utils/CloneFunction.cpp
@@ -40,6 +40,18 @@ using namespace llvm;
 
 #define DEBUG_TYPE "clone-function"
 
+namespace {
+void collectDebugInfoFromInstructions(const Function &F,
+                                      DebugInfoFinder &DIFinder) {
+  const Module *M = F.getParent();
+  if (M) {
+    // Inspect instructions to process e.g. DILexicalBlocks of inlined functions
+    for (const auto &I : instructions(F))
+      DIFinder.processInstruction(*M, I);
+  }
+}
+} // namespace
+
 /// See comments in Cloning.h.
 BasicBlock *llvm::CloneBasicBlock(const BasicBlock *BB, ValueToValueMapTy &VMap,
                                   const Twine &NameSuffix, Function *F,
@@ -146,12 +158,7 @@ DISubprogram *llvm::CollectDebugInfoForCloning(const Function &F,
   if (SPClonedWithinModule)
     DIFinder.processSubprogram(SPClonedWithinModule);
 
-  const Module *M = F.getParent();
-  if (M) {
-    // Inspect instructions to process e.g. DILexicalBlocks of inlined functions
-    for (const auto &I : instructions(F))
-      DIFinder.processInstruction(*M, I);
-  }
+  collectDebugInfoFromInstructions(F, DIFinder);
 
   return SPClonedWithinModule;
 }