[NFC][Cloning] Move DebugInfoFinder decl closer to its place of usage

[artempyanykh]

Stacked PRs:

• ->[NFC][Cloning] Move DebugInfoFinder decl closer to its place of usage #129154
• [NFC][Cloning] Clean up comments in CloneFunctionInto #129153
• [NFC][Cloning] Remove now unused CollectDebugInfoForCloning #129152
• [NFC][Cloning] Remove now unused FindDebugInfoToIdentityMap #129151
• [NFC][Coro] Remove now unused CommonDebugInfo in CoroSplit #129150
• [NFC][Coro] Use CloneFunctionInto for coroutine cloning instead of CloneFunction<Part> #129149

---

[NFC][Cloning] Move DebugInfoFinder decl closer to its place of usage

Summary:
This makes it clear that DIFinder is only really necessary for llvm.dbg.cu update.

Test Plan:
ninja check-llvm-unit

[llvmbot]

@llvm/pr-subscribers-coroutines

@llvm/pr-subscribers-llvm-transforms

Author: Artem Pianykh (artempyanykh)

Changes

Stacked PRs:

• ->#129154
• #129153
• #129152
• #129151
• #129150
• #129149
• #129148
• #129147
• #129146
• #129145
• #129144
• #129143

---

[NFC][Cloning] Move DebugInfoFinder decl closer to its place of usage

Summary:
This makes it clear that DIFinder is only really necessary for llvm.dbg.cu update.

Test Plan:
ninja check-llvm-unit

---

Full diff: https://github.com/llvm/llvm-project/pull/129154.diff

1 Files Affected:

• (modified) llvm/lib/Transforms/Utils/CloneFunction.cpp (+2-3)

diff --git a/llvm/lib/Transforms/Utils/CloneFunction.cpp b/llvm/lib/Transforms/Utils/CloneFunction.cpp
index 979cbad0d82c0..3af07594c848b 100644
--- a/llvm/lib/Transforms/Utils/CloneFunction.cpp
+++ b/llvm/lib/Transforms/Utils/CloneFunction.cpp
@@ -266,8 +266,6 @@ void llvm::CloneFunctionInto(Function *NewFunc, const Function *OldFunc,
   if (OldFunc->isDeclaration())
     return;
 
-  DebugInfoFinder DIFinder;
-
   if (Changes < CloneFunctionChangeType::DifferentModule) {
     assert((NewFunc->getParent() == nullptr ||
             NewFunc->getParent() == OldFunc->getParent()) &&
@@ -320,7 +318,8 @@ void llvm::CloneFunctionInto(Function *NewFunc, const Function *OldFunc,
     Visited.insert(Operand);
 
   // Collect and clone all the compile units referenced from the instructions in
-  // the function (e.g. as a scope).
+  // the function (e.g. as instructions' scope).
+  DebugInfoFinder DIFinder;
   collectDebugInfoFromInstructions(*OldFunc, DIFinder);
   for (auto *Unit : DIFinder.compile_units()) {
     MDNode *MappedUnit =

[felipepiovezan]

LGTM