[Mips] Do not emit instruction teq if divisor is non-zero immediate value in FastISel implementation #135768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yingopq
force-pushed
the
Fix_bug_issue_130629
branch
from
5bff92a to
84da4de
Compare
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
yingopq
force-pushed
the
Fix_bug_issue_130629
branch
from
84da4de to
c4ae12d
Compare
|
cc @wzssyqa |
|
Ping |
wzssyqa
reviewed
Apr 23, 2025
yingopq
force-pushed
the
Fix_bug_issue_130629
branch
from
c4ae12d to
8fa06ea
Compare
wzssyqa
reviewed
Apr 24, 2025
wzssyqa
reviewed
Apr 24, 2025
yingopq
force-pushed
the
Fix_bug_issue_130629
branch
from
8fa06ea to
126d7ba
Compare
wzssyqa
reviewed
Apr 25, 2025
…alue in FastISel implementation Add a check before emitting the teq instruction to check whether the divisor is a non-zero immediate value. Fix llvm#130629.
yingopq
force-pushed
the
Fix_bug_issue_130629
branch
from
126d7ba to
099c8fc
Compare
wzssyqa
approved these changes
Apr 25, 2025
qethu
pushed a commit
to zkMIPS/llvm-project
that referenced
this pull request
Apr 25, 2025
… FastISel implementation (llvm#135768) Add a check before emitting the teq instruction to check whether the divisor is a non-zero immediate value. Fix llvm#130629.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…alue in FastISel implementation (llvm#135768) Add a check before emitting the teq instruction to check whether the divisor is a non-zero immediate value. Fix llvm#130629.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…alue in FastISel implementation (llvm#135768) Add a check before emitting the teq instruction to check whether the divisor is a non-zero immediate value. Fix llvm#130629.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…alue in FastISel implementation (llvm#135768) Add a check before emitting the teq instruction to check whether the divisor is a non-zero immediate value. Fix llvm#130629.
Ankur-0429
pushed a commit
to Ankur-0429/llvm-project
that referenced
this pull request
May 9, 2025
…alue in FastISel implementation (llvm#135768) Add a check before emitting the teq instruction to check whether the divisor is a non-zero immediate value. Fix llvm#130629.
qethu
pushed a commit
to zkMIPS/llvm-project
that referenced
this pull request
May 10, 2025
… FastISel implementation (llvm#135768) Add a check before emitting the teq instruction to check whether the divisor is a non-zero immediate value. Fix llvm#130629.
qethu
pushed a commit
to zkMIPS/llvm-project
that referenced
this pull request
May 22, 2025
… FastISel implementation (llvm#135768) Add a check before emitting the teq instruction to check whether the divisor is a non-zero immediate value. Fix llvm#130629.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a check before emitting the teq instruction to check whether the divisor is a non-zero immediate value.
Fix #130629.