[mlir][ArmSME] Add mask operand to store_tile_slice #70838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-rhodes
force-pushed
the
mlir-arm-sme-store-tile-slice-mask
branch
from
240c712 to
26bb905
Compare
MacDue
reviewed
Nov 1, 2023
| $tile `,` $tile_slice_index `,` $base `[` $indices `]` (`layout` `` $layout^)? | ||
| attr-dict `:` type($base) `,` type($tile) | ||
| $tile `,` $tile_slice_index `,` $mask `,` $base `[` $indices `]` (`layout` `` $layout^)? | ||
| attr-dict `:` type($base) `,` type($mask) `,` type($tile) |
There was a problem hiding this comment.
Is this type($mask) needed? It should be inferred from your TileSliceMaskConstraint
There was a problem hiding this comment.
No it can be inferred as you say, but I decided to add the type anyway since this maps 1-1 with intrinsic. tile_load/tile_store are aligned with Vector transfer read/write so I didn't add mask type to asm for those.
The type is also present in load_tile_slice, we could remove in a follow-up if desired? I've don't mind either way.
There was a problem hiding this comment.
I prefer omitting the types that are very clear from context (i.e. the mask size must match the slice), but this is fine for now.
There was a problem hiding this comment.
Ok cool cheers, I'll post a follow-up :)
MacDue
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.