Skip to content

Make BytecodeOpInterface self-contained #98676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

pefoley2
Copy link

BytecodeOpInterface.h includes BytecodeReader.h and BytecodeWriter.h

However, the BytecodeReader and BytecodeWriter targets depend on the
BytecodeOpInterface target, so they can't be added to deps without
creating a circular dependency.

Work around this by adding the headers to srcs.

BytecodeOpInterface.h includes BytecodeReader.h and BytecodeWriter.h

However, the BytecodeReader and BytecodeWriter targets depend on the
BytecodeOpInterface target, so they can't be added to deps without
creating a circular dependency.

Work around this by adding the headers to srcs.
@pefoley2 pefoley2 requested review from rupprecht and keith as code owners July 12, 2024 18:27
Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@llvmbot llvmbot added the bazel "Peripheral" support tier build system: utils/bazel label Jul 12, 2024
@@ -8643,7 +8643,11 @@ gentbl_cc_library(

cc_library(
name = "BytecodeOpInterface",
srcs = ["lib/Bytecode/BytecodeOpInterface.cpp"],
srcs = [
"include/mlir/Bytecode/BytecodeReader.h",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked and we can drop this header from being included in BytecodeOpInterface, the other one we should probably refactor (e.g., extract the config out) so that the cmake and bazel builds are more similar.

Would you mind doing that along with this? (else I can too)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could take a crack at it, but I suspect it would be easier for you to do so given that I'm not terribly familiar with this codebase. I just ran across this with a project that happened to transitively depend on the llvm bazel rules.

jpienaar added a commit to jpienaar/llvm-project that referenced this pull request Jul 15, 2024
Flagged some additional headers missing in process.

Inspired by llvm#98676
jpienaar added a commit that referenced this pull request Jul 15, 2024
Flagged some additional headers missing in process.

Inspired by #98676
@pefoley2 pefoley2 closed this Jul 17, 2024
yuxuanchen1997 pushed a commit that referenced this pull request Jul 25, 2024
Flagged some additional headers missing in process.

Inspired by #98676
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bazel "Peripheral" support tier build system: utils/bazel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants