Skip to content

Make BytecodeOpInterface self-contained #98676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Make BytecodeOpInterface self-contained #98676

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8643,7 +8643,11 @@ gentbl_cc_library(

cc_library(
name = "BytecodeOpInterface",
srcs = ["lib/Bytecode/BytecodeOpInterface.cpp"],
srcs = [
"include/mlir/Bytecode/BytecodeReader.h",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked and we can drop this header from being included in BytecodeOpInterface, the other one we should probably refactor (e.g., extract the config out) so that the cmake and bazel builds are more similar.

Would you mind doing that along with this? (else I can too)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could take a crack at it, but I suspect it would be easier for you to do so given that I'm not terribly familiar with this codebase. I just ran across this with a project that happened to transitively depend on the llvm bazel rules.

"include/mlir/Bytecode/BytecodeWriter.h",
"lib/Bytecode/BytecodeOpInterface.cpp",
],
hdrs = [
"include/mlir/Bytecode/BytecodeImplementation.h",
"include/mlir/Bytecode/BytecodeOpInterface.h",
Expand Down
Loading