AdminAdobeStockInsertRenditionImageFromGalleryFileSizeTest #1835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sivaschenko
requested changes
Sep 16, 2020
There was a problem hiding this comment.
Thanks for the pull request @engcom-Golf ! Please see my comment
| <createData entity="SimpleSubCategory" stepKey="category"/> | ||
| <actionGroup ref="AdminLoginActionGroup" stepKey="loginAsAdmin"/> | ||
| <!-- Prepare configuration --> | ||
| <magentoCLI command="config:set system/media_gallery_renditions/width 50" stepKey="prepareWidth"/> |
There was a problem hiding this comment.
Please introduce an action group to set configuration values to MediaGalleryRenditions modules (please create a new pull request to magento2 for this purpose)
engcom-Golf
force-pushed
the
asi-1806
branch
from
9c33af2 to
912bec6
Compare
4 tasks
sivaschenko
added
has dependency
Priority: P3
sivaschenko
changed the title
|
@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B |
sivaschenko
approved these changes
Sep 21, 2020
m2-community-project
bot
added
Progress: ready for delivery
and removed
Progress: changes requested
labels
|
Hi @engcom-Golf, thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Related Pull Requests
https://github.com/magento/magento2/pull/30074/files
Cover issue by MFTF test by adding image from adobe stock inventory
Fixed Issues (if relevant)
#1806
Manual testing scenarios (*)
Preconditions:
Set rendition image size 50x50
Steps